[arch-releng] [PATCH 6/6] [RFC] Another batch of improvements for archiso hook

Gerardo Exequiel Pozzi vmlinuz386 at yahoo.com.ar
Wed Feb 17 17:53:22 EST 2010


On 02/17/2010 06:15 PM, Gerardo Exequiel Pozzi wrote:
> On 02/17/2010 05:30 AM, Thomas Bächler wrote:
>> Am 17.02.2010 06:57, schrieb Gerardo Exequiel Pozzi:
>>> * make /dev/loop0 at archiso install hook, to take advantage of
>>>    automatic module loading. There is no need for wait cycle.
>>> * Mount squashfs images directly with mount instead of first using
>>>    losetup, then mounting. These images are now mounted at
>>>    /tmpfs/mnt/name-of-the-image instead of /tmpfs/mnt/loopN
>>>    (count variable removed)
Implemented in single commit.
>>> * Use "/newroot" passed as argument to mount hook.
ops! This was implemented in the second patch (Not in the original 
posted in FS#18355)
>>> * Drop to a recovery shell in cases when FSTYPE detection fail 
>>> instead of
>>>    just fail, then kernel panic!
>>> * $newroot is passed to other _mnt_ functions in the same mountpoint.
>>> * $copytoram code is removed since does not work with AUFS.
>>> * Misc code style fixed.
Each in separated commits.

>> This looks all very good, can we get this broken up in single patches
>> (preferably with the "mount hook" parts merged with the previous patch)?
>>
> yes, I will see what I can do, in fact I am not very friend of making 
> several changes at once, but in this case there are several tightly 
> linked.
>
Done :) broken up in five patches.

-- 
Gerardo Exequiel Pozzi ( djgera )
http://www.djgera.com.ar
KeyID: 0x1B8C330D
Key fingerprint = 0CAA D5D4 CD85 4434 A219  76ED 39AB 221B 1B8C 330D




More information about the arch-releng mailing list