[arch-releng] [PATCH] Removes incorrect quotes in automated_script

[Gerardo Exequiel Pozzi]

On 04/26/2011 06:01 PM, Dieter Plaetinck wrote:
> On Tue, 26 Apr 2011 10:34:54 -0300
> Gerardo Exequiel Pozzi<vmlinuz386 at yahoo.com.ar>  wrote:
>
>> On 04/26/2011 09:08 AM, Charles Vejnar wrote:
>>> ---
>>>    .../overlay/etc/rc.d/functions.d/automated_script  |    2 +-
>>>    1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/configs/syslinux-iso/overlay/etc/rc.d/functions.d/automated_script b/configs/syslinux-iso/overlay/etc/rc.d/functions.d/automated_script
>>> index 076a49c..7a35acb 100644
>>> --- a/configs/syslinux-iso/overlay/etc/rc.d/functions.d/automated_script
>>> +++ b/configs/syslinux-iso/overlay/etc/rc.d/functions.d/automated_script
>>> @@ -3,7 +3,7 @@ automated_script ()
>>>        script="$(kernel_cmdline script)"
>>>        if [[ -n "$script" ]]; then
>>>            stat_busy "Configuring $script"
>>> -        if [[ "$script" =~ "^http://" || "$script" =~ "^ftp://" ]]; then
>>> +        if [[ "$script" =~ ^http:// || "$script" =~ ^ftp:// ]]; then
>>>                wget "$script" -q -O /tmp/startup_script>/dev/null
>>>                rt=$?
>>>            else
>> pushed to master. Thanks.
>>
>
> What?
> First you commit the useless quotes because they are "cosmetic".
Cosmetic in "$script" but regex.
> http://mailman.archlinux.org/pipermail/arch-releng/2011-April/001671.html
> Then you remove them again in a new commit.
>

> git history pollution...
I hope this disaster will not happen again...
> Dieter
>


-- 
Gerardo Exequiel Pozzi
\cos^2\alpha + \sin^2\alpha = 1