[arch-releng] [PATCH 2/2] [archiso] Allow persistent cow dm-snapshots.

[Gerardo Exequiel Pozzi]

On 08/23/2011 01:54 PM, Dave Reisner wrote:
> On Tue, Aug 23, 2011 at 12:40:48PM -0300, Gerardo Exequiel Pozzi wrote:
>> On 08/23/2011 11:01 AM, Gerardo Exequiel Pozzi wrote:
>>> On 08/23/2011 05:25 AM, Thomas Bächler wrote:
>>>> Am 23.08.2011 09:42, schrieb Gerardo Exequiel Pozzi:
>>>>> +* cow_label=        Set the filesystem label where COW (dm-snapshot)
>>>>> +                    files must be stored.
>>>>> +                    Default: (unset)
>>>>> +* cow_device=       Set the device node where COW (dm-snapshot) files
>>>>> +                    must be stored.
>>>>> +                    Default: (unset) or
>>>>> "/dev/disk/by-label/${cow_label}"
>>>> Does this support cow_device being identical to archisodevice? This
>>>> would be beneficial if you remaster the official ISO as
>>>> described in [1].
>>>>
>>>> [1]
>>>> https://wiki.archlinux.org/index.php/USB_Installation_Media#Without_overwriting_the_USB_drive
>>>>
>>>>
>>> True :)
>>> No, but I can do that if [[ ${cow_device} == ${archisodevice} ]]
>>>
>>> Thanks for the feedback!
>>>
>> rebased with
>>
>> -    _mnt_dev "${archisodevice}" "/bootmnt" "-r"
>> +    if [[ "$(readlink -f "${archisodevice}")" == "$(readlink -f
>> "${cow_device}")" ]]; then
>> +        _mnt_dev "${archisodevice}" "/bootmnt"
>> +    else
>> +        _mnt_dev "${archisodevice}" "/bootmnt" "-r"
>> +    fi
>> +
>>
>>
> Why not use [[ $archisodevice -ef $cow_device ]] ? from bash(1)...
>
>    file1 -ef file2
>      True if file1 and file2 refer to the same device and inode numbers.
>
> d
>
Is true!. Cool ash support it! But should be with quotes,  since [[ ]] 
in ash is not 100% like in bash (empty $var, spaces...)

Thanks for the feedback!


-- 
Gerardo Exequiel Pozzi
\cos^2\alpha + \sin^2\alpha = 1