[arch-releng] [PATCH 1/3] Rename interactive_grub_menulst to interactive_bootloader_menu
Matthew Gyurgyik
pyther at pyther.net
Mon Feb 21 19:06:14 EST 2011
On 02/21/2011 03:53 PM, Dieter Plaetinck wrote:
> On Sun, 20 Feb 2011 23:09:35 -0500
> pyther at pyther.net wrote:
>
>> Function was updated to be flexible with the use of multiple bootloaders
> Update function to ...
>> ---
>> src/core/libs/lib-ui-interactive.sh | 27 +++++++++++++++++----------
>> 1 files changed, 17 insertions(+), 10 deletions(-)
>>
>> diff --git a/src/core/libs/lib-ui-interactive.sh b/src/core/libs/lib-ui-interactive.sh
>> index b244a6e..85a3a5f 100644
>> --- a/src/core/libs/lib-ui-interactive.sh
>> +++ b/src/core/libs/lib-ui-interactive.sh
>> @@ -883,7 +883,7 @@ interactive_grub() {
>> fi
>> fi
>> # Create and edit the grub menu.lst
>> - interactive_grub_menulst
>> + interactive_bootloader_menu "GRUB" $grubmenu
> why 'GRUB' and not just 'grub' ?
> I really dislike needless capitalizing.
>
>
>> +interactive_bootloader_menu() {
>> + # $1 - Bootloader Name
>> + # $2 - Bootloader Configuration Files
> put the comments *above* the function name.
>
You told me to do this in chat and I did. I'm not sure why the patches I
submitted didn't reflect this. :( Anyways this is fixed
More information about the arch-releng
mailing list