[arch-releng] [PATCH] Rewrite of finddisks and findblockdevices. Rename findblockdevices to find_usable_devices

Dieter Plaetinck dieter at plaetinck.be
Mon Feb 28 15:14:58 EST 2011


How hard is it to just go over everything I asked, fix it and if you don't know what I mean, ask for clarifications? (I'm referring to my questions such as "non-block files such as?", the "extended partition" typo, my response to $hidebldev, and a few other remarks about comments)
It would at least be simpler then expecting me to do the same work multiple times.
But fuck it.. the code seems like good quality so I merged it and did some minor changes to your patch myself.
I want people to be able to test this new code.
I also cleaned up the commit message (<80 chars and it had the wrong function name and unclear info)

so yeah thanks, this is a nice contribution (and your other work aswell) after all. you just need to work a bit on being more thorough so we can work efficiently.

Dieter


More information about the arch-releng mailing list