[arch-releng] [PATCH] Define grubmenu as a global variable instead of multiple local variables

Matthew Gyurgyik pyther at pyther.net
Tue Jan 4 18:28:35 EST 2011


On 01/03/2011 10:30 PM, Matthew Gyurgyik wrote:
> On 01/03/2011 01:30 PM, Dieter Plaetinck wrote:
>> merged from your github.
>> thanks,
>> Dieter
> This needs to be reverted or the sourcing order needs to be changed....
>
> What happens is that when lib-ui-interactive.sh is sourced 
> $var_TARGET_DIR is not yet set, resulting in 
> grubmenu="$var_TARGET_DIR/boot/grub/menu.lst" equaling 
> /boot/grub/menu.lst instead of /mnt/boot/grub/menu.lst
>
> I attempted to figure out the sourcing order, however I failed. 
> var_TARGET_DIR is set in core/procedures/base. Maybe this can be 
> sourced before lib-ui-interactive?
>
> In my brief (non-rebooted) install test /boot/grub/menu.lst (on the 
> live cd) was being edited instead of the one on the target system 
> Since I didn't reboot I didn't realize this until I was working on my 
> Syslinux code.
>
> pyther
@dieter if you don't have the time to investigate this can you revert 
this change?


More information about the arch-releng mailing list