[arch-releng] [PATCH 2/2] releng: Add more (and more precise) clock choices

Dan McGee dpmcgee at gmail.com
Sun May 15 12:15:48 EDT 2011


On Sun, May 15, 2011 at 8:00 AM, Tom Willemsen <ryuslash at gmail.com> wrote:
>
> Signed-off-by: Tom Willemsen <ryuslash at gmail.com>

The grammar checker in me strikes again:
* If we're using full-stop punctuation (periods), we shouldn't be
doing this lowercase stuff nor omitting one at the end. I think it
makes more sense to use commas everywhere, no?
* "change clock NTP" needs something else in there, e.g. "change clock
using NTP" or "change clock with NTP".

-Dan

> ---
>  releng/fixtures/clockchoices.json |   55 +++++++++++++++++++++++++++++++++++--
>  1 files changed, 52 insertions(+), 3 deletions(-)
>
> diff --git a/releng/fixtures/clockchoices.json b/releng/fixtures/clockchoices.json
> index f328801..da1f429 100644
> --- a/releng/fixtures/clockchoices.json
> +++ b/releng/fixtures/clockchoices.json
> @@ -3,21 +3,70 @@
>        "pk": 1,
>        "model": "releng.clockchoice",
>        "fields": {
> -           "name": "unchanged"
> +           "name": "default region/timezone. keep clock"
>        }
>     },
>     {
>        "pk": 2,
>        "model": "releng.clockchoice",
>        "fields": {
> -           "name": "configured manually"
> +           "name": "default region/timezone. change clock manually (UTC)"
>        }
>     },
>     {
>        "pk": 3,
>        "model": "releng.clockchoice",
>        "fields": {
> -           "name": "NTP"
> +           "name": "default region/timezone. change clock NTP (UTC)"
> +       }
> +    },
> +    {
> +       "pk": 4,
> +       "model": "releng.clockchoice",
> +       "fields": {
> +           "name": "default region/timezone. change clock manually (localtime)"
> +       }
> +    },
> +    {
> +       "pk": 5,
> +       "model": "releng.clockchoice",
> +       "fields": {
> +           "name": "default region/timezone. change clock NTP (localtime)"
> +       }
> +    },
> +    {
> +       "pk": 6,
> +       "model": "releng.clockchoice",
> +       "fields": {
> +           "name": "update region/timezone. keep clock"
> +       }
> +    },
> +    {
> +       "pk": 7,
> +       "model": "releng.clockchoice",
> +       "fields": {
> +           "name": "update region/timezone. change clock manually (UTC)"
> +       }
> +    },
> +    {
> +       "pk": 8,
> +       "model": "releng.clockchoice",
> +       "fields": {
> +           "name": "update region/timezone. change clock NTP (UTC)"
> +       }
> +    },
> +    {
> +       "pk": 9,
> +       "model": "releng.clockchoice",
> +       "fields": {
> +           "name": "update region/timezone. change clock manually (localtime)"
> +       }
> +    },
> +    {
> +       "pk": 10,
> +       "model": "releng.clockchoice",
> +       "fields": {
> +           "name": "update region/timezone. change clock NTP (localtime)"
>        }
>     }
>  ]
> --
> 1.7.5.1
>
>


More information about the arch-releng mailing list