[arch-releng] [RFC] [PATCH] [syslinux-iso] Workaround download-repo.sh, remove extra gcc pkgs

[Dieter Plaetinck]

On Mon, 16 May 2011 12:57:28 -0300
Gerardo Exequiel Pozzi <vmlinuz386 at yahoo.com.ar> wrote:

> Signed-off-by: Gerardo Exequiel Pozzi <vmlinuz386 at yahoo.com.ar>
> ---
>  configs/syslinux-iso/download-repo.sh |   11 +++++++++--
>  1 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/configs/syslinux-iso/download-repo.sh b/configs/syslinux-iso/download-repo.sh
> index 255304e..78ce531 100755
> --- a/configs/syslinux-iso/download-repo.sh
> +++ b/configs/syslinux-iso/download-repo.sh
> @@ -38,7 +38,8 @@ fi
>  /usr/bin/pacman -Sy
>  
>  #Ensure we have core/pkgname format, so we don't get crap from other repos
> -PKGS=$(/usr/bin/pacman -Sl $REPO | cut -d' ' -f1,2 | tr ' ' '/')
> +#Workaround remove gcc-add gcc-fortran gcc-go gcc-objc from [core]
it's gcc-ada, not gcc-add. maybe also explain _why_ the workaround is needed.

> +PKGS=$(/usr/bin/pacman -Sl $REPO | grep -v "gcc-\(a\|f\|g\|o\)" | cut -d' ' -f1,2 | tr ' ' '/')
i would list them explicitly, that's more clear and more robust
>  
>  if [ -n "$PKGS" ]; then
>      baseurl=""
> @@ -58,7 +59,13 @@ if [ -n "$PKGS" ]; then
>          fi
>      done
>      if [ "$REPO_CHANGED" = "y" ]; then
> -        wget -nv "$baseurl/$REPO.db" -O "$DEST/$REPO.db"
> +        # wget -nv "$baseurl/$REPO.db" -O "$DEST/$REPO.db"
> +        #[workaround] remove gcc-add gcc-fortran gcc-go gcc-objc from [core]

gcc-ada. also, why leave the commented entry?

> +        wget -nv "$baseurl/$REPO.db.tar.gz" -O "$DEST/$REPO.db.tar.gz"
> +        repo-remove "$DEST/$REPO.db.tar.gz" gcc-ada gcc-fortran gcc-go gcc-objc
> +        mv "$DEST/$REPO.db.tar.gz" "$DEST/$REPO.db"
> +        rm "$DEST/$REPO.db.tar.gz.old"
> +        #[/workaround]
>      fi
>  else
>      echo "No packages to download... what'd you break?"