[arch-releng] [arch-install-scripts] [PATCH] common: mount efivarfs if possible, but don't bail out if it fails

[Dave Reisner]

On Nov 15, 2013 5:09 AM, "Thomas Bächler" <thomas at archlinux.org> wrote:
>
> Am 14.11.2013 20:58, schrieb Dave Reisner:
> > On Thu, Nov 14, 2013 at 07:15:31PM +0100, Thomas Bächler wrote:
> >> Installing EFI bootloaders during pacstrap is broken right now, as is
> >> installing manually in arch-chroot. Therefore, mount efivarfs if the
> >> host kernel supports it.
> >> ---
> >
> > Thanks, I pushed a different version of this patch which uses a new
> > convenience function I added, mount_conditionally:
> >
> >
https://projects.archlinux.org/arch-install-scripts.git/commit/?id=8f2bd395e
> >
https://projects.archlinux.org/arch-install-scripts.git/commit/?id=c746f87fc
>
> The last patch will still bail out if /sys/firmware/efi/efivars exists,
> but mounting efivarfs fails for some odd reason. While not mounting
> efivarfs is an undesirable situation, bailing out completely due to this
> failure is worse IMO.
>
> That's why I originally added '{ cmd || true } &&'
>
>

What makes this mount so special that we should avoid failing if it doesn't
mount? Why would it be any more or less prone to failure if it was
successfully mounted in the host?

You actually needed the || true logic regardless in your patch. If the dir
didn't exist on the host you'd break the mount chain. Some of us still run
ancient motherboards with bios only ;)