[arch-releng] [PATCH 1/1] explicitly detach loop device on umount

[Christian Hesse]

Gerardo Exequiel Pozzi <vmlinuz386 at gmail.com> on Tue, 2015/04/21 21:05:
> On 04/21/2015 07:43 PM, Christian Hesse wrote:
> > Gerardo Exequiel Pozzi <vmlinuz386 at gmail.com> on Tue, 2015/04/21 19:23:
> >> On 04/21/2015 02:57 AM, Christian Hesse wrote:
> >>> From: Christian Hesse <mail at eworm.de>
> >>>
> >>> I see cases where a stale loop device stays around and fills up my
> >>> partition as image file is still in use and does not get unlinked.
> >>>
> >>> Explicitly detach loop device on umount to fix that.
> >>>
> >>> Signed-off-by: Christian Hesse <mail at eworm.de>
> >>> ---
> >>>  archiso/mkarchiso       | 2 +-
> >>>  configs/releng/build.sh | 2 +-
> >>>  2 files changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/archiso/mkarchiso b/archiso/mkarchiso
> >>> index 0da02b0..bc82786 100755
> >>> --- a/archiso/mkarchiso
> >>> +++ b/archiso/mkarchiso
> >>> @@ -59,7 +59,7 @@ _mount_airootfs() {
> >>>  
> >>>  _umount_airootfs() {
> >>>      _msg_info "Unmounting '${work_dir}/mnt/airootfs'"
> >>> -    umount "${work_dir}/mnt/airootfs"
> >>> +    umount -d "${work_dir}/mnt/airootfs"
> >>>      _msg_info "Done!"
> >>>      rmdir "${work_dir}/mnt/airootfs"
> >>>      trap - EXIT HUP INT TERM
> >>> diff --git a/configs/releng/build.sh b/configs/releng/build.sh
> >>> index 5590163..86cdb08 100755
> >>> --- a/configs/releng/build.sh
> >>> +++ b/configs/releng/build.sh
> >>> @@ -190,7 +190,7 @@ make_efiboot() {
> >>>      cp ${work_dir}/iso/EFI/shellx64_v2.efi ${work_dir}/efiboot/EFI/
> >>>      cp ${work_dir}/iso/EFI/shellx64_v1.efi ${work_dir}/efiboot/EFI/
> >>>  
> >>> -    umount ${work_dir}/efiboot
> >>> +    umount -d ${work_dir}/efiboot
> >>>  }
> >>>  
> >>>  # Build airootfs filesystem image
> >>>
> >>
> >> Hi Chris,
> > 
> > Hi Gerardo, hi Pierre,
> > 
> > (Pierre, CCing you as you build the official media.)
> > 
> >> Weird, I never experienced such thing, maybe some kind of race
> >> condition. I guess should be reported to upstream.
> > 
> > I had some problems with systemd 219... It 'magically' umounts loop
> > mounts, which breaks archiso.
> 
> Oh systemd-219, I personally reverted back temporary to 218 in my two
> main systemd (I can do directly since I do not use remote journal
> feature (gnutls soname rebuild)).
> 
> In any case, at least archiso boots fine with 219.

Looks like systemd 219-6 addresses this issue.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/arch-releng/attachments/20150422/5f88eed4/attachment.asc>