[arch-releng] [PATCH 1/3] use consistent syntax for boot parameter processing

Christian Hesse list at eworm.de
Fri Jan 2 18:05:40 UTC 2015


Gerardo Exequiel Pozzi <vmlinuz386 at gmail.com> on Fri, 2015/01/02 14:58:
> On 01/02/2015 07:23 AM, Christian Hesse wrote:
> > From: Christian Hesse <mail at eworm.de>
> > 
> > Signed-off-by: Christian Hesse <mail at eworm.de>
> > ---
> >  archiso/initcpio/hooks/archiso | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/archiso/initcpio/hooks/archiso
> > b/archiso/initcpio/hooks/archiso index addd08a..1bd9419 100644
> > --- a/archiso/initcpio/hooks/archiso
> > +++ b/archiso/initcpio/hooks/archiso
> > @@ -100,9 +100,7 @@ run_hook() {
> >      [[ -z "${archisobasedir}" ]] && archisobasedir="arch"
> >      [[ -z "${dm_snap_prefix}" ]] && dm_snap_prefix="arch"
> >      [[ -z "${archisodevice}" ]] &&
> > archisodevice="/dev/disk/by-label/${archisolabel}"
> > -    if [[ -z "${cowfile_size}" ]]; then
> > -        cowfile_size="256M"
> > -    fi
> > +    [[ -z "${cowfile_size}" ]] && cowfile_size="256M"
> >  
> >      if [[ -n "${cow_label}" ]]; then
> >          cow_device="/dev/disk/by-label/${cow_label}"
> > 
> 
> Nice, thanks Christian.
> 
> Note: I made another changed in my local repo (in overlayfs branch) that
> change this parameter to cow_spacesize=, it makes more sense, since this
> option is shared to setup tmpfs space for both methods (dm-snap and
> overlayfs).

Agreed. ;)

I thought about renaming it as well but hesitated to break backward
compatibility. But with overlayfs it makes even more sense.

Do you want me to send a rebased patch?
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/arch-releng/attachments/20150102/bad364b1/attachment.bin>


More information about the arch-releng mailing list