[arch-releng] [archiso] [GIT] branch master updated (02164ac -> 5a57d83)

[Eli Schwartz]

On 06/27/2018 10:47 PM, Gerardo Exequiel Pozzi via arch-releng wrote:
> El 24/06/18 a las 19:52, Eli Schwartz via arch-releng escribió:
>> On 06/24/2018 11:50 AM, Gerardo Exequiel Pozzi via arch-releng wrote:
>>> This is an automated email from the git hooks/post-receive script.
>>>
>>> djgera pushed a change to branch master
>>> in repository archiso.
>>>
>>>     from 02164ac  [releng] support for -P iso_publisher and -A iso_application in build.sh
>>>      new 5a57d83  [archiso] Use --sysroot when list installed packages.
>>>
>>> The 1 revisions listed above as "new" are entirely new to this
>>> repository and will be described in separate emails.  The revisions
>>> listed as "add" were already present in the repository and have only
>>> been added to this reference.
>>>
>>>
>>> Detailed log of new commits:
>>>
>>> commit 5a57d8396457aa7360529948a4f2a43fe9f400fd
>>> Author: Gerardo Exequiel Pozzi <vmlinuz386 at gmail.com>
>>> Date:   Sun Jun 24 12:48:52 2018 -0300
>>>
>>>     [archiso] Use --sysroot when list installed packages.
>>>     
>>>     Signed-off-by: Gerardo Exequiel Pozzi <vmlinuz386 at gmail.com>
>>>
>>> Summary of changes:
>>>  archiso/mkarchiso | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> You should drop the --config flag when moving to --sysroot.
>>
>> pacman --root uses the config from the host system, and gets told to use
>> the archiso configured pacman.conf. Though, in theory, once the workdir
>> is created it could use "${work_dir}/airootfs/etc/pacman.conf" as copied
>> over by the prior pacstrap invocation.
>>
>> The --sysroot will resolve "${pacman_conf}" relative to
>> "${work_dir}/airootfs" which is certainly wrong, and should be using the
>> aforementioned version copied by pacstrap. Since --sysroot is
>> fundamentally about just treating the chroot the way you'd think a
>> chroot system should be treated, this means *within the chroot* it uses
>> the default /etc/pacman.conf.
>>
>> So, just drop the whole --config parameter for more lines of code
>> removed/simplified. :D
>>
> 
> There is an issue here, that I was suspected, and now confirmed.
> 
> Build with custom pacman.conf, for example to enable [testing], since in
> "chroot" pacman.conf is the default, not the customized version, package
> list made is incomplete.
> 
> Not a big issue for releng profile, since always use the default repos,
> but for other purposes... cumstomized pacman.conf should be copied on
> build.sh (in any case is the most logic thing to do).

mkarchroot also copies over any specified pacman.conf.
Or to be more accurate, it utilizes arch-nspawn which does so.

The pacman.conf will get used both for configuring the initial pacstrap,
and getting copied into the chroot for later use.

IMHO this is reasonable behavior for mkarchiso to emulate.

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/arch-releng/attachments/20180627/596c5dc9/attachment.asc>