[aur-dev] [PATCH] Fixed a couple more lingering JSON bugs

Loui louipc.ist at gmail.com
Tue Feb 19 13:29:50 EST 2008


On Tue, Feb 19, 2008 at 12:11 PM, eliott <eliott at cactuswax.net> wrote:
>  Your patch adds a needless string concatenation operation, for the
>  sole sake of a line break.
>  Not a good idea. String concatenation adds up, peformance wise.

Sorry I wasn't aware of that. I really hate the long lines though.
It's a lot easier to work with code that fits neatly within a certain
number of columns (for me). Even with the performance hit I'd probably
still go for it. I bet there's a lot of other places that performance
can be improved.

I've just read something about an output buffer that sounds like it
might increase performance for all output strings. Should we go about
using that in the rest of the code where applicable?




More information about the aur-dev mailing list