[aur-dev] [PATCH] removed obsolete inline CSS in index.php
louipc.ist at gmail.com
Sat Jun 7 13:29:29 EDT 2008
On Sun, 8 Jun 2008 01:18:30 +0800
"Callan Barrett" <wizzomafizzo at gmail.com> wrote:
> On Sun, Jun 8, 2008 at 1:06 AM, Michael Klier <chi at chimeric.de> wrote:
> > Angel Velásquez wrote:
> >> Oh hi Michael, good, but, i have to be annoying again (and sorry) but
> >> what about with the double and simple quotes subject? i know that the
> >> file was originally written bad, but try at least to don't copy and
> >> paste things like:
> >> print "</th>";
> >> print "</tr>";
> >> Remember, double quotes and simple quotes are important even if you
> >> think that 'both works'. I tried to said you this in the other mail,
> >> and i thought that you understood (i hope this time you will), thanks
> >> anyway, but please try to clean the code (or maybe i say optimize it?)
> >> before submit a patch, isn't the idea to patch and re-patch with
> >> bad-written-code.
> >> Thanks!
> > Here's another attempt (patch attached to the mail this time), I hope I got it
> > right this time :). Now I've change the quoting style like you said for the
> > changed line as well as the surrounding html block. In one case I've also
> > fixed the indentation (to use tabs) as it seemed the right step to me (that
> > still leaves enough bad quoting to fix, but I was asked to also keep the diffs
> > short).
> > Kind Regards,
> > Michael
> > --
> > Michael Klier
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.6 (GNU/Linux)
> > iD8DBQFISsAAAuL1i4MI9VERAtzzAJ9opmnUI16MpmaYHx54MSrWd3sBGgCgjK3U
> > GlAV71ZvIo+GZp2C+wNM9YY=
> > =brxq
> > -----END PGP SIGNATURE-----
> I've applied the first patch (what quotes you use isn't really vital)
> and my own, this one splits the html entirely from the index page and
> puts it in a template file. If you want please please take a look at
> this, what you're already doing is awesome and that template is html
> soup. I couldn't even indent it.
Hmm I don't think that the index page should be sent to a template file.
I think the point of the template file is to take html out of
functions and the libraries. The code in web/html shouldn't be
considered as functions/libraries but rather just html (unfortunately
it's not the case right how hehe). So I'm thinking the logic parts of
index.html should be put into a library rather than the html parts
being put into a template.
More information about the aur-dev