[aur-dev] [PATCH] Redirect on package submission

Callan Barrett wizzomafizzo at gmail.com
Sun Jun 29 12:12:59 EDT 2008


On a successful package submit there will be a redirect to the package details
page of the packages, no more successful message

Also got rid of the $warning stuff, what the hell was that for?

Signed-off-by: Callan Barrett <wizzomafizzo at gmail.com>
---
 web/html/pkgsubmit.php |   46 ++++++++++++++++------------------------------
 1 files changed, 16 insertions(+), 30 deletions(-)

diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php
index 4d15ebe..f1fec64 100644
--- a/web/html/pkgsubmit.php
+++ b/web/html/pkgsubmit.php
@@ -12,17 +12,6 @@ include("pkgfuncs.inc");    # package functions
 
 set_lang();                 # this sets up the visitor's language
 check_sid();                # see if they're still logged in
-html_header("Submit");
-
-?>
-
-<div class="pgbox">
-  <div class="pgboxtitle">
-    <span class="f3"><?php print __("Submit"); ?></span>
-  </div>
-  <div class="pgboxbody">
-
-<?php
 
 if ($_COOKIE["AURSID"]):
   
@@ -342,6 +331,8 @@ if ($_COOKIE["AURSID"]):
 					$q .= $pdata["ID"] . ", '" . mysql_real_escape_string($src) . "')";
 					db_query($q, $dbh);
 			  }
+			
+				header('Location: /packages.php?ID=' . $pdata['ID']);
 			  
 			} else {
 			  
@@ -385,6 +376,8 @@ if ($_COOKIE["AURSID"]):
 					$q .= $packageID . ", '" . mysql_real_escape_string($src) . "')";
 					db_query($q, $dbh);
 			  }
+			
+				header('Location: /packages.php?ID=' . $packageID);
 			  
 			}
 		}
@@ -392,7 +385,19 @@ if ($_COOKIE["AURSID"]):
 		chdir($_SERVER['DOCUMENT_ROOT']);
 	}
 
+# Logic over, let's do some output
+
+html_header("Submit");
+
+?>
+
+<div class="pgbox">
+  <div class="pgboxtitle">
+    <span class="f3"><?php print __("Submit"); ?></span>
+  </div>
+  <div class="pgboxbody">
 
+<?php
 	if (!$_REQUEST["pkgsubmit"] || $error):
 		# User is not uploading, or there were errors uploading - then
 		# give the visitor the default upload form
@@ -405,14 +410,6 @@ if ($_COOKIE["AURSID"]):
 
 <?php
 			endif;
-			if ($warning):
-?>
-
-<br><span class='error'><?php print $warning; ?></span><br />
-<br />
-
-<?php
-			endif;
             
 			$pkg_categories = pkgCategories();
 			$pkg_locations = pkgLocations();
@@ -461,17 +458,6 @@ if ($_COOKIE["AURSID"]):
 
 <?php
 		endif;
-	else:
-		print __("Package upload successful.");
-
-    if ($warning):
-?>
-
-<span class='warning'><?php print $warning; ?></span><br />
-<br />
-
-<?php
-    endif;
 	endif;
 else:
 	# Visitor is not logged in
-- 
1.5.5.3





More information about the aur-dev mailing list