[aur-dev] [PATCH] Tweak TU interface for appearance.

[Loui Chang]

-------------- next part --------------
>From e91344e4e01fcd90eb002cf13db651b036ab9c26 Mon Sep 17 00:00:00 2001
From: Loui Chang <louipc.ist at gmail.com>
Date: Sun, 9 Nov 2008 19:35:17 -0500
Subject: [PATCH] Tweak TU interface for appearance.

Show ten votes per page instead of five.
Change the vote preview to 75 characters so entries fit better
in the table.
Remove [More] links and make the description itself a link.
Clean up a couple notices.
Send unauthorised users to index.php.

Signed-off-by: Loui Chang <louipc.ist at gmail.com>
---
 web/html/addvote.php     |    1 -
 web/html/tu.php          |   21 +++++++++++++--------
 web/template/tu_list.php |    6 +++---
 3 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/web/html/addvote.php b/web/html/addvote.php
index 449bbb0..6b30e49 100644
--- a/web/html/addvote.php
+++ b/web/html/addvote.php
@@ -91,4 +91,3 @@ if ($atype == "Trusted User" OR $atype == "Developer") {
 
 html_footer(AUR_VERSION);
 
-?>
diff --git a/web/html/tu.php b/web/html/tu.php
index 67ac3f2..0b8b5c7 100644
--- a/web/html/tu.php
+++ b/web/html/tu.php
@@ -9,7 +9,8 @@ check_sid();
 html_header();
 
 # Default votes per page
-$pp = 5;
+$pp = 10;
+$prev_Len = 75;
 
 $atype = "";
 if (isset($_COOKIE["AURSID"])) {
@@ -17,7 +18,6 @@ if (isset($_COOKIE["AURSID"])) {
 }
 
 if ($atype == "Trusted User" OR $atype == "Developer") {
-	$pp = 5;
 
 	if (isset($_GET['id'])) {
 		if (is_numeric($_GET['id'])) {
@@ -87,9 +87,14 @@ if ($atype == "Trusted User" OR $atype == "Developer") {
 	} else {
 		$dbh = db_connect();
 		
-		$offset = $_GET['off'];
 		$limit = $pp;
-		$by = $_GET['by'];
+		if (isset($_GET['off']))
+			$offset = $_GET['off'];
+
+		if (isset($_GET['by']))
+			$by = $_GET['by'];
+		else
+			$by = 'up';
 
 		if (!empty($offset) AND is_numeric($offset)) {
 			if ($offset >= 1) {
@@ -105,8 +110,6 @@ if ($atype == "Trusted User" OR $atype == "Developer") {
 		$lim = ($limit > 0) ? " LIMIT " . $off . ", " . $limit : "";
 		$by_next = ($by == "down") ? "up" : "down";
 
-		$prev_Len = 100;
-
 		$q = "SELECT * FROM TU_VoteInfo WHERE End > " . time() . " ORDER BY Submitted " . $order;
 		$result = db_query($q, $dbh);
 
@@ -146,8 +149,10 @@ if ($atype == "Trusted User" OR $atype == "Developer") {
 </table>
 <?php
 	}
-} else {
-	print __("You are not allowed to access this area.");
+}
+else {
+	header('Location: index.php');
 }
 
 html_footer(AUR_VERSION);
+
diff --git a/web/template/tu_list.php b/web/template/tu_list.php
index bec2985..83c9a48 100644
--- a/web/template/tu_list.php
+++ b/web/template/tu_list.php
@@ -26,12 +26,12 @@
 					<td class='<?php print $c ?>'><span class='f4'><span class='blue'>
 						<?php
 						if (strlen($row["Agenda"]) >= $prev_Len) {
-							$row["Agenda"] = htmlentities(substr($row["Agenda"], 0, $prev_Len)) . "... - ";
+							$row["Agenda"] = htmlentities(substr($row["Agenda"], 0, $prev_Len)) . "...";
 						} else {
-							$row["Agenda"] = htmlentities($row["Agenda"]) . " - ";
+							$row["Agenda"] = htmlentities($row["Agenda"]);
 						}
 						?>
-						<?php print $row["Agenda"] ?><a href='/tu.php?id=<?php print $row['ID'] ?>'>[<?php print __("More") ?>]</a></span></span>
+						<a href='tu.php?id=<?php print $row['ID'] ?>'><?php print $row["Agenda"] ?></a></span></span>
 					</td>
 					<td class='<?php print $c ?>'><span class='f5'><span class='blue'><?php print gmdate("j M y", $row["Submitted"]) ?></span></span></td>
 					<td class='<?php print $c ?>'><span class='f5'><span class='blue'><?php print gmdate("j M y", $row["End"]) ?></span></span></td>
-- 
1.6.0.3