[aur-dev] [PATCH] Revert "Use system rm in rm_rf function."

[Dan McGee]

On Fri, Oct 24, 2008 at 6:46 PM, Loui <louipc.ist at gmail.com> wrote:
> On Fri, Oct 24, 2008 at 04:29:01PM -0500, Dan McGee wrote:
>> This reverts commit 5c3f01909301f641f57b2ffe8b59609de6be2256. Falling back
>> to a system function is really dumb when all we need to do is fix the
>> ordering of things in this function.
>
> Falling back on a system function can be dumb, but it seems that PHP
> unlink() is unable to handle self-referencing symlinks. So this what I
> optioned to do. I tried to look for another way to no avail.
>
> Am I doing something wrong perhaps?

Looks like it is due to PHP security restrictions, not
self-referencing symlinks. If you create a symlink to a bogus
location, PHP is unable to delete it because of the default
open_basedir restructions.
ln -s testfile testlink
php -r 'unlink("testlink");'

The file still exists. So that means one of two things:
1. Remove any open_basedir restrictions
2. Just shell out to do it since we have that command enabled (or do we?)

>> I sent the last patches based off of the master branch- looks like I have no
>> idea how your development works, sorry about that. Anyway here is the series
>> based off of the testing branch. It still will need some testing.
>
> Haha yeah that's mentioned in HACKING on the testing branch. Doh.

Just a FYI- pretty much every other project I've hacked on using GIT
uses master as their location of the current work. :)

-Dan