[aur-dev] [PATCH] Fix: FS#13122 - simpler commented line removal

Loui Chang louipc.ist at gmail.com
Sun Feb 15 19:07:09 EST 2009


On Mon, Feb 16, 2009 at 07:25:59AM +0800, Gergely Imreh wrote:
> 2009/2/16 Loui Chang <louipc.ist at gmail.com>:
> >> 2009/2/14 Gergely Imreh <imrehg at gmail.com>:
> >> >  This patch should fix the way commented lines are removed. Should
> >> > generally work with all lines (variables) AUR cares about. Removed
> >> > previous (incomplete) method.
> >
> > Hmm this fixes it for comments outside of braces, but it breaks the
> > parsing for parameter substitution. Oy.
> > _kernelname=${pkgname#kernel26}
> >
> 
> Ok, let me check it, I haven't seen such replacement that you mention,
> yet, so didn't expect it... Let bash be blessed. :)

Oh there was no replacement, but the parser was able to handle it
gracefully (?) before.

Now it's showing an error:
Invalid name: only lowercase letters are allowed.

I was using the PKGBUILD submitted in this
http://bugs.archlinux.org/task/13173 for testing.



More information about the aur-dev mailing list