[aur-dev] [Patch] FS#12698
Gergely Imreh
imrehg at gmail.com
Sun Jan 11 10:23:00 EST 2009
2009/1/11 Dan McGee <dpmcgee at gmail.com>:
> On Sat, Jan 10, 2009 at 9:45 PM, Gergely Imreh <imrehg at gmail.com> wrote:
>> Hi,
>>
>> Attached is a proposed fix to AUR bug #12698.
>> I tested it with the official kernel26 PKGBUILD (among others) that
>> would show this bug in the current version.
>
> This could still fail on the corner case where the '#' sign is located
> inside a quoted block of text, e.g.:
> echo "## finished building ##"
>
> I don't think URLs can ever contain a '#' sign though, so we are good there.
>
> -Dan
>
Would it? The new code only replaces # within when making the
variablename=( ) blocks into a single line. It wouldn't touch anything
within build(), I think....
If the URL would contain #, then makepkg would fail just the same.
Greg
More information about the aur-dev
mailing list