[aur-dev] [PATCH] Add timestamp when a package is flagged out-of-date (FS#20848).

Loui Chang louipc.ist at gmail.com
Fri Oct 1 22:39:37 EDT 2010


On Thu 30 Sep 2010 18:19 +0200, Lukas Fleischer wrote:
> ---
>  UPGRADING                     |    4 ++++
>  support/schema/aur-schema.sql |    1 +
>  web/lang/cs.po                |    2 +-
>  web/lang/de.po                |    2 +-
>  web/lang/el_GR.po             |    2 +-
>  web/lang/fr.po                |    2 +-
>  web/lang/he.po                |    2 +-
>  web/lang/hr.po                |    2 +-
>  web/lang/hu.po                |    2 +-
>  web/lang/it.po                |    2 +-
>  web/lang/nb_NO.po             |    2 +-
>  web/lang/pl.po                |    2 +-
>  web/lang/ro.po                |    2 +-
>  web/lang/ru.po                |    2 +-
>  web/lang/sr.po                |    2 +-
>  web/lang/tr.po                |    2 +-
>  web/lang/uk.po                |    2 +-
>  web/lang/zh_CN.po             |    2 +-
>  web/lib/pkgfuncs.inc          |    3 ++-
>  web/template/pkg_details.php  |    3 ++-
>  20 files changed, 25 insertions(+), 18 deletions(-)
> 
> diff --git a/UPGRADING b/UPGRADING
> index 743f404..99c5d1a 100644
> --- a/UPGRADING
> +++ b/UPGRADING
> @@ -1,6 +1,10 @@
>  Upgrading
>  =========
>  
> +From 1.7.0
> +----------
> +ALTER TABLE Packages ADD OutOfDateTS BIGINT UNSIGNED NOT NULL;
> +
>  From 1.6.0 to 1.7.0
>  -------------------
>  ALTER TABLE Users ADD Salt CHAR(32) NOT NULL DEFAULT '';
> diff --git a/support/schema/aur-schema.sql b/support/schema/aur-schema.sql
> index 250d405..15705a3 100644
> --- a/support/schema/aur-schema.sql
> +++ b/support/schema/aur-schema.sql
> @@ -120,6 +120,7 @@ CREATE TABLE Packages (
>  	LocationID TINYINT UNSIGNED NOT NULL DEFAULT 1,
>  	NumVotes INTEGER UNSIGNED NOT NULL DEFAULT 0,
>  	OutOfDate TINYINT UNSIGNED DEFAULT 0,
> +	OutOfDateTS BIGINT UNSIGNED NOT NULL,
>  	SubmittedTS BIGINT UNSIGNED NOT NULL,
>  	ModifiedTS BIGINT UNSIGNED NOT NULL,
>  	SubmitterUID INTEGER UNSIGNED NOT NULL DEFAULT 0,     -- who submitted it?

I was thinking - could we just change things so that OutOfDateTS is the
sole indicator of whether a package has been flagged or not?

If it's set, then it's out of date.
If it's zero or null, then it's up to date.

This might also apply to deletion, or orphan requests.
Really all these types of flagging could share the same structure and
code as far as I can envision it.

Also, I think that all these translation changes are really unnecessary.



More information about the aur-dev mailing list