[aur-dev] [PATCH 3/4] reformat
elij.mx at gmail.com
Tue Apr 5 23:47:07 EDT 2011
On Tue, Apr 5, 2011 at 7:25 PM, elij <elij.mx at gmail.com> wrote:
> On Tue, Apr 5, 2011 at 6:54 PM, Dan McGee <dpmcgee at gmail.com> wrote:
>> On Tue, Apr 5, 2011 at 7:54 PM, elij <elij.mx at gmail.com> wrote:
>>> - make the sql nicer and more readable
>>> - convert to spaces. who uses tabs in python!?
>> -1. These should not be done in the same patch.
> They were both solely formatting changes, and changed no underlying
> logic or behavior. It seemed reasonable for me to include them both in
> the same patch.
huh. Actually, looking at the patch it looks like the commit message
is not quite right, as that patch _is_ just changing tabs to spaces.
I *think* when I wrote the commit message I was thinking about the
previous commit that had accidentally changed the spacing of something
(the sql blocks) when I hadn't realized things were tabular, and the
previous commit was actually a breaking commit (bad me). It was easier
to fix it via ":retab" than it was to track down the errant space/tab
and redo the previous commit. I imagine if I had done a rebase and
merged those two commits, then I would have gotten a -1 like I did
So it really was just changing tabs to spaces, but that _also_ fixed a
bug that I had introduced by not realizing it was all tabs. Bad commit
More information about the aur-dev