[aur-dev] [PATCH 2/7] add minified aur css

[Lukas Fleischer]

On Wed, Apr 06, 2011 at 02:18:22PM -0500, Dan McGee wrote:
> On Wed, Apr 6, 2011 at 2:15 PM, Lukas Fleischer
> <archlinux at cryptocrack.de> wrote:
> > On Mon, Apr 04, 2011 at 02:44:06PM -0700, elij wrote:
> >> ---
> >>  web/html/css/aur.min.css |  148 ++++++++++++++++++++++++++++++++++++++++++++++
> >>  1 files changed, 148 insertions(+), 0 deletions(-)
> >>  create mode 100644 web/html/css/aur.min.css
> >>
> >> diff --git a/web/html/css/aur.min.css b/web/html/css/aur.min.css
> >> new file mode 100644
> >> index 0000000..51380bb
> >> --- /dev/null
> >> +++ b/web/html/css/aur.min.css
> >> @@ -0,0 +1,148 @@
> >> +span{color:#555;font-family:Bitstream Vera Sans, Lucida Grande, Arial, sans-serif;}
> >> +span.f1{font-size:20px;letter-spacing:1px;}
> >> +span.f2{font-size:14px;color:#6c83b0;font-weight:bold;}
> >> +span.f3{color:#888;font-size:14px;font-weight:bold;padding-right:2px;}
> >> +span.f4{color:#444;font-size:12px;}
> >> +span.f5{color:#333;font-size:11px;}
> >> +span.f6{color:#b06d6e;font-size:14px;font-weight:bold;}
> >> +span.f7{color:#6db06d;font-size:14px;font-weight:bold;}
> >> +span.f8{color:#888;font-size:12px;font-weight:bold;}
> >> +span.fix{color:#000;font-family:monospace, fixed, terminal;font-size:12px;}
> >> [...]
> >
> > Imho, we should at least add some comments and split stuff into sections
> > (7 or 8 additional bytes shouldn't make a difference). Otherwise this
> > becomes confusing...
> 
> I'm not sure I agree with the patchset (this is minimal gain here; our
> CSS is not extensive), but your point is a tad off base. The whole
> point of minified CSS is it is generated and not meant for human
> consumption ever. It should always be generated via some compressor
> program.
> 
> Of course, the commit message should be saying this to ease these
> concerns before they are even raised, not me...

Oh, yeah. I missed the point here and tought this was some reformatting
applied to the main stylesheet. The commit message should definitely
contain some note on how this was achieved.

After all, I don't think I'm gonna push this one anyways. As Dan said,
it's minimal gain and adds extra work to every patch affecting the
stylesheets (or at least before each release, in case we would decide to
re-create minimal stylesheets before releasing).