[aur-dev] [PATCH 3/3] convert to spaces

[elij]

On Wed, Apr 6, 2011 at 1:16 PM, Lukas Fleischer
<archlinux at cryptocrack.de> wrote:
> On Wed, Apr 06, 2011 at 12:59:10PM -0700, elij wrote:
>> On Wed, Apr 6, 2011 at 12:06 PM, Lukas Fleischer
>> <archlinux at cryptocrack.de> wrote:
>> > On Tue, Apr 05, 2011 at 11:57:48PM -0700, elij wrote:
>> >> reformat with recommendation from pep8 for using spaces
>> >> ---
>> >>  support/schema/gendummydata.py |  256 ++++++++++++++++++++--------------------
>> >>  1 files changed, 128 insertions(+), 128 deletions(-)
>> >
>> > Won't push that one, as long as we don't agree on an amendment of our
>> > coding standards. Refer to "HACKING".
>>
>> Ah. That is too bad.
>> I consider pep8 coding convention to be a 'good smell' when
>> contributing to python codebases.
>>
>> Based on patch feedback so far, it seems like our standards and
>> conventions are too dissimilar to be beneficial.
>
> I didn't say this is a no-go but we need to discuss this one and fix our
> coding guidelines if we agree on pushing this changeset. There already
> is some inconsistency with aurblup using spaces for indentation so this
> certainly is an area we need to work on.
>
>> I will fix up the previous patch-set and resend it, then I will stop
>> wasting my time and yours.
>
> Dude, I hope you don't take our feedback personal. I'm just trying to
> keep inconsistent and inconvenient stuff out of the code base as it
> already is way too patchy. Your patches are highly appreciated and I'll
> definitely push some of them if you clean them up.

It is nothing personal. It just seems that my convention and coding
style is not compatible with the aur team of today. Like I said, I am
just trying to not waste your time or mine.

Don't feel bad, or as if you drove someone away.
You are the aur lead, so things *do* need to be optimized for your
consumption and style/convention.