[aur-dev] [PATCH] Remove unnecessary atype and uid lookup from package_details

Dan McGee dan at archlinux.org
Thu Aug 11 09:42:50 EDT 2011


These were never used in the function, causing at least two totally
unnecessary queries, and potentially two more as each retrieved a DB
handle and would execute the 'SET NAMES...' bit in there.

Signed-off-by: Dan McGee <dan at archlinux.org>
---
 web/lib/pkgfuncs.inc.php |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/web/lib/pkgfuncs.inc.php b/web/lib/pkgfuncs.inc.php
index ca6a0f9..65758c8 100644
--- a/web/lib/pkgfuncs.inc.php
+++ b/web/lib/pkgfuncs.inc.php
@@ -301,9 +301,6 @@ function pkgname_is_blacklisted($name, $dbh=NULL) {
 # display package details
 #
 function package_details($id=0, $SID="", $dbh=NULL) {
-	$atype = account_from_sid($SID);
-	$uid = uid_from_sid($SID);
-
 	if(!$dbh) {
 		$dbh = db_connect();
 	}
-- 
1.7.6



More information about the aur-dev mailing list