From nick at afternight.org  Thu Dec  1 09:14:00 2011
From: nick at afternight.org (Nick Lanham)
Date: Thu, 01 Dec 2011 15:14:00 +0100
Subject: [aur-dev] Select All in Package Listing
Message-ID: <4ED78BA8.10303@afternight.org>

There was some talk on the aur-general list about how it would be nice 
to have a select all option on the package listing page.  This patch 
adds that.

Note that I just dropped the javascript into a <script> tag as, as far 
as i can tell, there isn't any central location for js stuff.  If that's 
a problem, I can move it elsewhere.

Regards,

Nick Lanham
-------------- next part --------------
A non-text attachment was scrubbed...
Name: aur_check_all.patch
Type: text/x-patch
Size: 907 bytes
Desc: not available
URL: <http://mailman.archlinux.org/pipermail/aur-dev/attachments/20111201/38fdd655/attachment.bin>

From archlinux at cryptocrack.de  Fri Dec  2 04:25:43 2011
From: archlinux at cryptocrack.de (Lukas Fleischer)
Date: Fri, 2 Dec 2011 10:25:43 +0100
Subject: [aur-dev] [PATCH] Remove maxlength on password fields
In-Reply-To: <CAGTUsj_SbOK+w=K5GNrwBCWFGSgsKgyKgMK+X=eEVMztQd5azQ@mail.gmail.com>
References: <CAGTUsj8zOePg_G_FVbVEh6C8XEEi88ckdqcFj3Jb2juOg0voTA@mail.gmail.com>
 <20111125111644.GA8795@blizzard>
 <CAGTUsj-ZATexsvdjpyiZbJzG1meYhTebq4nKpiuKDj-BwBSQmA@mail.gmail.com>
 <20111125143440.GC8795@blizzard>
 <CAGTUsj_SbOK+w=K5GNrwBCWFGSgsKgyKgMK+X=eEVMztQd5azQ@mail.gmail.com>
Message-ID: <20111202092543.GA18088@blizzard>

On Fri, Nov 25, 2011 at 03:43:57PM +0100, Stein Magnus Jodal wrote:
> On Fri, Nov 25, 2011 at 15:34, Lukas Fleischer <archlinux at cryptocrack.de> wrote:
> > On Fri, Nov 25, 2011 at 01:30:05PM +0100, Stein Magnus Jodal wrote:
> >> On Fri, Nov 25, 2011 at 12:16, Lukas Fleischer <archlinux at cryptocrack.de> wrote:
> >> > You should try to configure your MUA not to break long lines when
> >> > sending patches... The best alternative is to use `git send-email` :)
> >>
> >> Sorry, I'm usually using GitHub for all git cooperation, and Gmail is
> >> really suboptimal for sending patches :-)
> >
> > You can add a link to your GitHub repository next time you send a patch
> > so that I can pull and don't have to go through the pain of fixing the
> > patch before feeding it to git-am(1).
> 
> Is attaching the patch to the email okay? The HACKING file was rather
> specific on the patch being attached inline in the email.

Attachments are sometimes stripped. We really prefer inline patches.
Once you get used to git-send-email(1), you'll never use anything else!

> 
> -- 
> Stein Magnus Jodal

From archlinux at cryptocrack.de  Fri Dec  2 04:35:34 2011
From: archlinux at cryptocrack.de (Lukas Fleischer)
Date: Fri, 2 Dec 2011 10:35:34 +0100
Subject: [aur-dev] Select All in Package Listing
In-Reply-To: <4ED78BA8.10303@afternight.org>
References: <4ED78BA8.10303@afternight.org>
Message-ID: <20111202093534.GB18088@blizzard>

On Thu, Dec 01, 2011 at 03:14:00PM +0100, Nick Lanham wrote:
> There was some talk on the aur-general list about how it would be
> nice to have a select all option on the package listing page.  This
> patch adds that.

Please send full Git-formatted patches (generated by
git-format-patch(1)) and please send them inline instead of attaching
stuff.

> 
> Note that I just dropped the javascript into a <script> tag as, as
> far as i can tell, there isn't any central location for js stuff.
> If that's a problem, I can move it elsewhere.

Well, the reason for not having a central location for JavaScript stuff
is because we (that's me, basically) don't like JavaScript :) If we ever
feel the need for such a thing, it should definitely be put in a central
location, though.

Also, there's a lot of design changes going on right now and all
design/interface related patches should probably be delayed until
everything is merged into master. Could you wait for a while and
resubmit this patch when all the hard work is done? :) You can also open
a feature request in the meantime, so we don't lose track of this one.

> 
> Regards,
> 
> Nick Lanham

> diff --git a/web/template/pkg_search_results.php b/web/template/pkg_search_results.php
> index 8ef352b..45173bb 100644
> --- a/web/template/pkg_search_results.php
> +++ b/web/template/pkg_search_results.php
> @@ -10,12 +10,22 @@
>  			</div>
>  
>  
> -
> -
> -<table class='results'>
> +<script type="text/javascript">
> +  function clickAll(box,table) {
> +      var checks = table.getElementsByTagName("input"); 
> +      for (var i = 0; i < checks.length; i++) 
> +	  checks[i].checked = box.checked
> +  }
> +</script> 
> +<table class='results' id='result_table'>
>  <tr>
>  	<?php if ($SID): ?>
> -	<th class='header'>&nbsp;</th>
> +	<th class='header' style='text-align:left'>
> +		<input type='checkbox'
> +		       title='<?php print __("Select All/None") ?>'
> +		       onClick='clickAll(this,document.getElementById("result_table"))' 
> +		       name='SelAllCheck' value='1' />
> +	</th>
>  	<?php endif; ?>
>  
>  	<th class='header'><span class='f2'>


From nick at afternight.org  Fri Dec  2 05:12:24 2011
From: nick at afternight.org (Nick Lanham)
Date: Fri, 02 Dec 2011 11:12:24 +0100
Subject: [aur-dev] Select All in Package Listing
In-Reply-To: <20111202093534.GB18088@blizzard>
References: <4ED78BA8.10303@afternight.org> <20111202093534.GB18088@blizzard>
Message-ID: <4ED8A488.2040909@afternight.org>

Yeah, sorry about the patch format, I should have read the guidelines 
more carefully.  I will get it right when I re-submit.

I realized that there was probably a conscious avoidance of javascript 
(which I'm generally for too), but for modifying dom elements like this, 
it really does make sense.  There would be a more convoluted way to do 
it, sort of like how search is done, with a new request and a parameter 
to indicate that all checkboxes should be checked or un-checked, so if 
there's really a desire to keep js out of the code, let me know, and 
I'll try to get that working for the re-submit.

Regards,

Nick

On 12/02/2011 10:35 AM, Lukas Fleischer wrote:
> On Thu, Dec 01, 2011 at 03:14:00PM +0100, Nick Lanham wrote:
>> There was some talk on the aur-general list about how it would be
>> nice to have a select all option on the package listing page.  This
>> patch adds that.
> Please send full Git-formatted patches (generated by
> git-format-patch(1)) and please send them inline instead of attaching
> stuff.
>
>> Note that I just dropped the javascript into a<script>  tag as, as
>> far as i can tell, there isn't any central location for js stuff.
>> If that's a problem, I can move it elsewhere.
> Well, the reason for not having a central location for JavaScript stuff
> is because we (that's me, basically) don't like JavaScript :) If we ever
> feel the need for such a thing, it should definitely be put in a central
> location, though.
>
> Also, there's a lot of design changes going on right now and all
> design/interface related patches should probably be delayed until
> everything is merged into master. Could you wait for a while and
> resubmit this patch when all the hard work is done? :) You can also open
> a feature request in the meantime, so we don't lose track of this one.
>
>> Regards,
>>
>> Nick Lanham
>> diff --git a/web/template/pkg_search_results.php b/web/template/pkg_search_results.php
>> index 8ef352b..45173bb 100644
>> --- a/web/template/pkg_search_results.php
>> +++ b/web/template/pkg_search_results.php
>> @@ -10,12 +10,22 @@
>>   			</div>
>>
>>
>> -
>> -
>> -<table class='results'>
>> +<script type="text/javascript">
>> +  function clickAll(box,table) {
>> +      var checks = table.getElementsByTagName("input");
>> +      for (var i = 0; i<  checks.length; i++)
>> +	  checks[i].checked = box.checked
>> +  }
>> +</script>
>> +<table class='results' id='result_table'>
>>   <tr>
>>   	<?php if ($SID): ?>
>> -	<th class='header'>&nbsp;</th>
>> +	<th class='header' style='text-align:left'>
>> +		<input type='checkbox'
>> +		       title='<?php print __("Select All/None") ?>'
>> +		       onClick='clickAll(this,document.getElementById("result_table"))'
>> +		       name='SelAllCheck' value='1' />
>> +	</th>
>>   	<?php endif; ?>
>>
>>   	<th class='header'><span class='f2'>

From andrea at archlinux.org  Fri Dec  9 04:49:34 2011
From: andrea at archlinux.org (Andrea Scarpino)
Date: Fri,  9 Dec 2011 10:49:34 +0100
Subject: [aur-dev] [PATCH] Set the title in the Trusted User page
Message-ID: <1323424174-5250-1-git-send-email-andrea@archlinux.org>

---
 web/html/tu.php |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/web/html/tu.php b/web/html/tu.php
index 6e202c8..6e04353 100644
--- a/web/html/tu.php
+++ b/web/html/tu.php
@@ -5,7 +5,10 @@ set_include_path(get_include_path() . PATH_SEPARATOR . '../lib');
 include_once("aur.inc.php");
 set_lang();
 check_sid();
-html_header();
+
+$title = __("Trusted User");
+
+html_header($title);
 
 # Default votes per page
 $pp = 10;
-- 
1.7.8


From archlinux at cryptocrack.de  Sat Dec 17 08:55:22 2011
From: archlinux at cryptocrack.de (Lukas Fleischer)
Date: Sat, 17 Dec 2011 14:55:22 +0100
Subject: [aur-dev] [PATCH] Set the title in the Trusted User page
In-Reply-To: <1323424174-5250-1-git-send-email-andrea@archlinux.org>
References: <1323424174-5250-1-git-send-email-andrea@archlinux.org>
Message-ID: <20111217135522.GA3573@blizzard>

On Fri, Dec 09, 2011 at 10:49:34AM +0100, Andrea Scarpino wrote:
> ---
>  web/html/tu.php |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 

Pushed, thanks!

> diff --git a/web/html/tu.php b/web/html/tu.php
> index 6e202c8..6e04353 100644
> --- a/web/html/tu.php
> +++ b/web/html/tu.php
> @@ -5,7 +5,10 @@ set_include_path(get_include_path() . PATH_SEPARATOR . '../lib');
>  include_once("aur.inc.php");
>  set_lang();
>  check_sid();
> -html_header();
> +
> +$title = __("Trusted User");
> +
> +html_header($title);
>  
>  # Default votes per page
>  $pp = 10;
> -- 
> 1.7.8

From archlinux at cryptocrack.de  Sat Dec 17 09:00:59 2011
From: archlinux at cryptocrack.de (Lukas Fleischer)
Date: Sat, 17 Dec 2011 15:00:59 +0100
Subject: [aur-dev] [PATCH 0/5] Package details view layout changes
In-Reply-To: <CAEik5nP2EZY8Pb-4dbSduRfiEvpLf5+wD_MJCmXzqVNPB3W-=A@mail.gmail.com>
References: <1320414177-22877-1-git-send-email-archlinux@cryptocrack.de>
 <CAEik5nP2EZY8Pb-4dbSduRfiEvpLf5+wD_MJCmXzqVNPB3W-=A@mail.gmail.com>
Message-ID: <20111217140059.GB3573@blizzard>

On Fri, Nov 04, 2011 at 10:28:33AM -0500, Dan McGee wrote:
> On Fri, Nov 4, 2011 at 8:42 AM, Lukas Fleischer
> <archlinux at cryptocrack.de> wrote:
> > This patch set basically syncs the package details layout with what
> > archweb uses and makes the rendered page, as well as the source code,
> > look cleaner and more consistent.
> >
> > I plan to put more efforts in cleaning up our HTML and making the AUR
> > integrate well with the rest of www.archlinux.org. We might eventually
> > just use "archweb.css" with a few AUR-specific extensions.
> I'd be happy to ensure compatibility on this and keeping differences
> to a minimum or zero.
> 
> > Any objections from the "Arch Linux/AUR segregation" front..?
> >
> > Dan, any objections?
> Nope. I didn't look in detail at all of the patches but generally
> seems fine to me, as long as AUR is prominent somewhere near the top
> of the page and in the page title.

I rebased all of these patches and refactored several parts of the AUR
website, based on the archweb layout. You can find these changes in my
"archweb-integration" branch [1]. Note that I might rebase this branch
from time to time, so be prepared when setting up a tracking branch.

The most important parts are already fixed but there's still a lot of
things to do. Comments and suggestions welcome!

> 
> > Lukas Fleischer (5):
> > ?pkg_details.php: Use a table for package details
> > ?pkg_details.php: Add link to category search
> > ?pkg_details.php: Sync metadata layout with archweb
> > ?pkg_details.php: Sync package actions layout with archweb
> > ?pkg_details.php: Use sane format for date strings
> I realized I signed off on these date strings, but also noticed the
> dates on the front page stats and such are in the ugly format- might
> want to touch those up too.
> 
> >
> > ?web/html/css/arch.css ? ? ? ?| ? ?3 -
> > ?web/html/css/containers.css ?| ? 81 +++++++++++++++
> > ?web/template/pkg_details.php | ?226 +++++++++++++++++++++---------------------
> > ?3 files changed, 196 insertions(+), 114 deletions(-)
> >
> > --
> > 1.7.7.2
> >
> >

[1] http://git.cryptocrack.de/aur.git/?h=archweb-integration