[aur-dev] [PATCH] Drop PackageLocations table and references

[Lukas Fleischer]

On Sat, Jan 29, 2011 at 04:20:06PM -0600, Dan McGee wrote:
> We don't need this anymore since all packages managed here are
> well...managed here. Rip out all of the places we were using this field,
> many of which depended on the magic value '2' anyway.
> 
> On the display side of things, we had a column that was always showing
> 'unsupported' that is now gone, and you can no longer sort by this column.

Sounds like a good idea to me. I just applied it to my working tree and
it basically looks fine. As far as I can see by now, you only broke one
SQL query:

> @@ -324,9 +293,8 @@ function package_details($id=0, $SID="") {
>  	$atype = account_from_sid($SID);
>  	$uid = uid_from_sid($SID);
>  
> -	$q = "SELECT Packages.*,Location,Category ";
> -	$q.= "FROM Packages,PackageLocations,PackageCategories ";
> -	$q.= "WHERE Packages.LocationID = PackageLocations.ID ";
> +	$q = "SELECT Packages.*,Category ";
> +	$q.= "FROM Packages,PackageCategories ";
>  	$q.= "AND Packages.CategoryID = PackageCategories.ID ";

... should be patched to use "WHERE" instead of "AND" of course.

>  	$q.= "AND Packages.ID = " . intval($id);
>  	$dbh = db_connect();

Apart from this, I have no objections against pushing this. I already
commited that to my working tree. Just let me do some more testing :)