[aur-dev] [PATCH 1/2] Fix performance issues with new PackageDepends lookups

[Lukas Fleischer]

On Wed, Jun 22, 2011 at 10:04:10AM -0500, Dan McGee wrote:
> We do a lookup by DepName in the package details view, but I made the
> silly mistake of forgetting this index addition in the upgrade steps.
> 
> Signed-off-by: Dan McGee <dan at archlinux.org>
> ---
> 
> Not sure if this fell through the cracks way back in April...

Oh, yeah. I somehow missed that. Thanks for the reminder.

> 
>  UPGRADING                     |    6 ++++--
>  support/schema/aur-schema.sql |    1 +
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/UPGRADING b/UPGRADING
> index ad7ad96..51afad3 100644
> --- a/UPGRADING
> +++ b/UPGRADING
> @@ -9,9 +9,11 @@ each AUR upgrade by running `make install` in the "po/" directory.
>  
>  2. Remove the "NewPkgNotify" column from the "Users" table:
>  
> -----
>  ALTER TABLE Users DROP COLUMN NewPkgNotify;
> -----
> +
> +3. Fix up issues with depends performance on large dataset.
> +
> +ALTER TABLE PackageDepends ADD INDEX (DepName);
>  
>  3. Rename "web/lib/config.inc" to "web/lib/config.inc.php".

Seems like you forgot to adjust the numbering when rebasing the patch.
I'll fix that and push later.

>  
> diff --git a/support/schema/aur-schema.sql b/support/schema/aur-schema.sql
> index e64ae82..88d074e 100644
> --- a/support/schema/aur-schema.sql
> +++ b/support/schema/aur-schema.sql
> @@ -123,6 +123,7 @@ CREATE TABLE PackageDepends (
>  	DepName VARCHAR(64) NOT NULL,
>  	DepCondition VARCHAR(20),
>  	INDEX (PackageID),
> +	INDEX (DepName),
>  	FOREIGN KEY (PackageID) REFERENCES Packages(ID) ON DELETE CASCADE
>  ) ENGINE = InnoDB;
>  
> -- 
> 1.7.5.4