[aur-dev] [PATCH 2/3] aurblup: mark all functions and global variables static

Lukas Fleischer archlinux at cryptocrack.de
Tue Jun 28 03:06:26 EDT 2011


On Mon, Jun 27, 2011 at 05:31:31PM -0500, Dan McGee wrote:
> These don't need visibility outside of this compilation unit. This also
> allows a C compiler to inline and optimize as it sees fit.
> 
> Signed-off-by: Dan McGee <dan at archlinux.org>
> ---
>  scripts/aurblup/aurblup.c |   46 ++++++++++++++++++++++----------------------
>  1 files changed, 23 insertions(+), 23 deletions(-)
> 

Holy sh**... Yeah, just pushed those!

On Mon, Jun 27, 2011 at 05:31:32PM -0500, Dan McGee wrote:
> We don't need to add rules for implicit .c -> .o conversions. Also add
> -O2 to the CFLAGS as gcc doesn't print many warnings unless at least
> some level of optimization is used.
> 
> Signed-off-by: Dan McGee <dan at archlinux.org>
> ---
>  scripts/aurblup/Makefile  |    4 ----
>  scripts/aurblup/config.mk |    2 +-
>  2 files changed, 1 insertions(+), 5 deletions(-)
> 

... and this one as well.

Thanks!


More information about the aur-dev mailing list