[aur-dev] Patch submission for AUR login form

[Lukas Fleischer]

On Thu, May 05, 2011 at 11:30:31AM +0300, Kārlis wrote:
> Hi!
> 
> This is my first patch submission for an open source project, I really
> hope that patch format is right. I added label fields in the aur login
> form (wrapping the "Username:", "Password:" and "Remember me").
> Nothing fancy, but it will be better than trying to click in the small
> checkbox.

Yeah, it's ok :) You may prefer to use git-send-email(1) which is what
most people here use.

> 
> Cheers,
> -Karlis

> From 9fa0f9e690e7426f5986f4f41b91a184aaa6d861 Mon Sep 17 00:00:00 2001
> From: Karlis Lauva <skazhy at gmail.com>
> Date: Thu, 5 May 2011 09:19:59 +0300
> Subject: [PATCH] Added label tags for login form fields.
> 
> ---
>  web/template/login_form.php |   11 ++++++-----
>  1 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/web/template/login_form.php b/web/template/login_form.php
> index ab00071..25bf4d0 100644
> --- a/web/template/login_form.php
> +++ b/web/template/login_form.php
> @@ -13,14 +13,15 @@ else {
>  ?>
>  <form method="post" action="<?php echo $_SERVER['REQUEST_URI'] ?>">
>  	<div>
> -	<?php print __('Username') . ':'; ?>
> -	<input type="text" name="user" size="30" maxlength="<?php print USERNAME_MAX_LEN; ?>" value="<?php
> +	<label for="user"><?php print __('Username') . ':'; ?></label>
> +	<input type="text" name="user" id="user" size="30" maxlength="<?php print USERNAME_MAX_LEN; ?>" value="<?php
>  	if (isset($_POST['user'])) {
>  		print htmlspecialchars($_POST['user'], ENT_QUOTES);
>  	} ?>" />
> -	<?php print __('Password') . ':'; ?>
> -	<input type="password" name="passwd" size="30" maxlength="<?php print PASSWD_MAX_LEN; ?>" />
> -	<input type="checkbox" name="remember_me" /><?php print __("Remember me"); ?>
> +	<label for="passwd"><?php print __('Password') . ':'; ?></label>
> +	<input type="password" name="passwd" id="passwd" size="30" maxlength="<?php print PASSWD_MAX_LEN; ?>" />
> +	<input type="checkbox" name="remember_me" id="remember_me" />
> +    <label for="remember_me"><?php print __("Remember me"); ?></label>

You should always use tabs for indentation. Amended that before pushing.

>  	<input type="submit" class="button" value="<?php  print __("Login"); ?>" />
>  	<a href="passreset.php">[<?php echo __('Forgot Password') ?>]</a>
>  	</div>
> -- 
> 1.7.5
> 

Thanks! :)