[aur-dev] [PATCH 2/4] test return value from db_query before assuming it is valid

Lukas Fleischer archlinux at cryptocrack.de
Wed May 11 10:19:58 EDT 2011


On Tue, May 10, 2011 at 09:01:28PM -0700, elij wrote:
> make the sql query form consistent in usage by cleaning up
> instances where db_query's result was not inspected before
> attempting to fetch row data from the handle
> ---
>  web/html/addvote.php             |   16 +++++-
>  web/html/tu.php                  |   17 +++++-
>  web/lib/acctfuncs.inc            |   59 +++++++++++--------
>  web/lib/aur.inc                  |    8 ++-
>  web/lib/pkgfuncs.inc             |  116 +++++++++++++++++++++----------------
>  web/template/actions_form.php    |   52 ++++++++++--------
>  web/template/pkg_search_form.php |    2 +-
>  web/template/tu_list.php         |    8 ++-
>  8 files changed, 172 insertions(+), 106 deletions(-)
> 

Yeah, cool. I guess there's some more places that need to get fixed but
that looks like a good start.

Could you please resend that one without the formatting changes? They
make it kinda hard to spot the actual changes.


More information about the aur-dev mailing list