[aur-dev] [PATCH] Add a new AUR_LOCATION setting
Lukas Fleischer
archlinux at cryptocrack.de
Thu Oct 20 11:45:34 EDT 2011
On Thu, Oct 20, 2011 at 05:19:21PM +0200, Lukas Fleischer wrote:
> On Thu, Oct 20, 2011 at 09:22:17AM -0500, Dan McGee wrote:
> > This should be set to something like 'http://localhost' for development
> > or 'https://aur.archlinux.org' in production. It ensures all links in
> > the site stay in the development site and there is no sudden jump from
> > development to production environments.
> >
> > Signed-off-by: Dan McGee <dan at archlinux.org>
> > ---
> > web/html/passreset.php | 2 +-
> > web/lib/config.inc.php.proto | 3 +++
> > web/lib/pkgfuncs.inc.php | 2 +-
> > web/template/header.php | 2 +-
> > web/template/login_form.php | 2 +-
> > web/template/pkg_comment_form.php | 4 ++--
> > 6 files changed, 9 insertions(+), 6 deletions(-)
> >
>
> +1. Thanks!
Oh. Seems like I was a bit too hasty here :)
* web/lib/config.inc.php.proto: 'AUR_LOCATION = "http://localhost"' is
supposed to be '$AUR_LOCATION = "http://localhost"'. Note the dollar
sign ("$").
* We need to tell PHP that "$AUR_LOCATION" is a global variable whenever
it's used inside a function (sometimes this is quite difficult to
notice, "web/template/login_form.php", for example, is included in
"web/template/header.php" which, again, is included in html_header()
in "web/lib/aur.inc.php" - we should probably test every single line
this patch touches to make sure we don't break anything here).
More information about the aur-dev
mailing list