[aur-dev] [PATCH] Move SUPPORTED_LANGS out of config.inc.php

[Dan McGee]

On Thu, Oct 20, 2011 at 10:51 AM, Lukas Fleischer
<archlinux at cryptocrack.de> wrote:
> On Thu, Oct 20, 2011 at 05:19:30PM +0200, Lukas Fleischer wrote:
>> On Thu, Oct 20, 2011 at 09:27:18AM -0500, Dan McGee wrote:
>> > This has no real business being here, and is a pain to update when new
>> > languages are shipped. Move it to aur.inc.php instead so it doesn't
>> > overwhelm the user-configurable settings file with static stuff.
>> >
>> > Signed-off-by: Dan McGee <dan at archlinux.org>
>> > ---
>> >  web/lib/aur.inc.php          |   28 ++++++++++++++++++++++++++++
>> >  web/lib/config.inc.php.proto |   28 ----------------------------
>> >  2 files changed, 28 insertions(+), 28 deletions(-)
>> >
>>
>> Thanks!
>
> ... and we should make sure that we set "$SUPPORTED_LANGS" before
> calling set_lang() in "web/lib/aur.inc.php". Sorry for being imprudent.

Ugh. Yeah, this is a mess. Why the hell are we doing both general
function defines in this file and actually running code? I feel like
the first 16 lines or so should stay here, and boot all the functions
to another file.

-Dan