[aur-dev] [PATCH 0/6] [RFC] Virtual path feature

canyonknight at gmail.com canyonknight at gmail.com
Tue Jul 17 15:37:32 EDT 2012


On Sun, Jul 15, 2012 at 5:23 PM, Lukas Fleischer
<archlinux at cryptocrack.de> wrote:
> This implements nicer looking URLs, such as "/packages/" instead of
> "/packages.php", "/packages/$pkgname/" instead of "/packages.php?ID=$id"
> etc.
>
> Note that these patches are not ready to be merged yet but I'd like to
> get some comments. We'd probably also have to add rewrite rules to our
> AUR setup on sigurd or add legacy rules to the routing back end to
> ensure old URLs still work.
>

I didn't realize you were already merging these. Setting
$USE_VIRTUAL_URLS = false seems broken on my test setup. I'm getting a
call to an undefined function error on any page besides index.php. I'm
guessing that the include_once("routing.inc.php") should really be in
aur.inc.php not in index.php?

It also seems that all CSS doesn't load properly. I'm guessing this is
related to the change to absolute URI paths for stylesheets?

Sorry I don't have much time to fully review these but this is what
I've seen so far.

Regards,

Jason


More information about the aur-dev mailing list