[aur-dev] [PATCH] pkgsubmit: count actual subdirectories

[Dave Reisner]

On Sun, Mar 18, 2012 at 11:11:50AM -0400, Loui Chang wrote:
> On Sat 17 Mar 2012 22:35 -0400, Dave Reisner wrote:
> > Rather than relying on a regex, detect directories in the uploaded
> > tarball and count the slashes. This avoids problems with bsdtar
> > inserting PaxHeader attributes into the archive which look something
> > like the following to Archive_Tar:
> > 
> >   PaxHeader/xcursor-protozoa
> >   xcursor-protozoa/
> >   xcursor-protozoa/PaxHeader/PKGBUILD
> >   xcursor-protozoa/PKGBUILD
> > 
> > This only occurs on certain filesystems (e.g. jfs), but the tarball is
> > by no means invalid. When extracted, it will only contain the PKGBUILD
> > within a single subdirectory.
> 
> Just wondering, are these PaxHeaders, as well as Schily tags something
> that you'd really want to even keep in the archive if they're filesystem
> dependent? I suppose the AUR should be able to deal with these cases,
> but it would be nice if makepkg would produce filesystem agnostic source
> package too.
> 
> Maybe the AUR should reject them just as well, for the sake of a more
> consistent format.
> 
> Of interest:
> https://bugs.archlinux.org/task/28802
> https://www.gnu.org/software/tar/manual/html_section/Portability.html
> 

Thanks for the flyspray link.

I see no reason for the AUR to reject the tarball -- it's not invalid,
and especially not invalid as per the reason given by the error. IMO, we
should either fix the error (silly) or simply ignore the headers.

d