[aur-dev] [PATCH] Remove character limit on password length

canyonknight canyonknight at gmail.com
Tue Oct 9 16:37:18 EDT 2012


As all new passwords are hashed and therefore stored in the database
at the same length, this limitation is no longer needed.

Fixes FS#31855

Signed-off-by: canyonknight <canyonknight at gmail.com>
---
 web/html/login.php                 | 2 +-
 web/html/passreset.php             | 4 ++--
 web/lib/config.inc.php.proto       | 1 -
 web/template/account_edit_form.php | 4 ++--
 4 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/web/html/login.php b/web/html/login.php
index ed323f8..d5bb1e7 100644
--- a/web/html/login.php
+++ b/web/html/login.php
@@ -32,7 +32,7 @@ html_header('AUR ' . __("Login"));
 			</p>
 			<p>
 				<label for="id_password"><?= __('Password') . ':'; ?></label>
-				<input id="id_password" type="password" name="passwd" size="30" maxlength="<?= PASSWD_MAX_LEN; ?>" />
+				<input id="id_password" type="password" name="passwd" size="30" />
 			</p>
 			<p>
 				<input type="checkbox" name="remember_me" id="id_remember_me" />
diff --git a/web/html/passreset.php b/web/html/passreset.php
index 13697b9..42dfc86 100644
--- a/web/html/passreset.php
+++ b/web/html/passreset.php
@@ -86,11 +86,11 @@ html_header(__("Password Reset"));
 			</tr>
 			<tr>
 				<td><?= __("Enter your new password:"); ?></td>
-				<td><input type="password" name="password" size="30" maxlength="32" /></td>
+				<td><input type="password" name="password" size="30" /></td>
 			</tr>
 			<tr>
 				<td><?= __("Confirm your new password:"); ?></td>
-				<td><input type="password" name="confirm" size="30" maxlength="32" /></td>
+				<td><input type="password" name="confirm" size="30" /></td>
 			</tr>
 		</table>
 		<br />
diff --git a/web/lib/config.inc.php.proto b/web/lib/config.inc.php.proto
index 3c7df19..f132445 100644
--- a/web/lib/config.inc.php.proto
+++ b/web/lib/config.inc.php.proto
@@ -15,7 +15,6 @@ define( "URL_DIR", "/packages/" );
 define( "USERNAME_MIN_LEN", 3 );
 define( "USERNAME_MAX_LEN", 16 );
 define( "PASSWD_MIN_LEN", 4 );
-define( "PASSWD_MAX_LEN", 128 );
 
 # Default language for displayed messages in the web interface.
 define("DEFAULT_LANG", "en");
diff --git a/web/template/account_edit_form.php b/web/template/account_edit_form.php
index 20f552a..308913d 100644
--- a/web/template/account_edit_form.php
+++ b/web/template/account_edit_form.php
@@ -60,13 +60,13 @@
 
 		<p>
 			<label for="id_passwd1"><?= __("Password") ?>:</label>
-			<input type="password" size="30" maxlength="32" name="P" id="id_passwd1" value="<?= $P ?>" />
+			<input type="password" size="30" name="P" id="id_passwd1" value="<?= $P ?>" />
 			<?php if ($A != "UpdateAccount"): print " (".__("required").")"; endif; ?>
 		</p>
 
 		<p>
 			<label for="id_passwd2"><?= __("Re-type password") ?>:</label>
-			<input type="password" size="30" maxlength="32" name="C" id="id_passwd2" value="<?= $C ?>" />
+			<input type="password" size="30" name="C" id="id_passwd2" value="<?= $C ?>" />
 			<?php if ($A != "UpdateAccount"): print " (".__("required").")"; endif; ?>
 		</p>
 
-- 
1.7.12.2



More information about the aur-dev mailing list