[aur-dev] [PATCH 1/2] Removed unused mysql_num_rows result, changed while-loop check from lazy-one to default one

[Mario Mueller]

I'll double check that.

Von meinem iPhone gesendet

Am 17.09.2012 um 17:20 schrieb "canyonknight at gmail.com"
<canyonknight at gmail.com>:

> On Mon, Sep 17, 2012 at 8:11 AM,  <mario at xenji.com> wrote:
>> From: "Mario (xenji) Mueller" <mario at xenji.com>
>>
>> Signed-off-by: Mario (xenji) Mueller <mario at xenji.com>
>> ---
>> web/lib/acctfuncs.inc.php | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php
>> index d58c759..6f7c98a 100644
>> --- a/web/lib/acctfuncs.inc.php
>> +++ b/web/lib/acctfuncs.inc.php
>> @@ -327,9 +327,8 @@ function search_results_page($UTYPE,$O=0,$SB="",$U="",$T="",
>>        }
>>
>>        $result = db_query($q, $dbh);
>> -       $num_rows = mysql_num_rows($result);
>
> Is this really unused? I can't check right now, but I have a feeling
> this breaks account searching. The account search results page is
> finicky and needs a lot of work (pagination more like package results
> page, GET requests rather than POST, etc).
>
>>
>> -       while ($row = mysql_fetch_assoc($result)) {
>> +       while (($row = mysql_fetch_assoc($result)) != false) {
>
> I don't know Lukas' preference here. A style for this should probably
> be established and used.
>
>>                $userinfo[] = $row;
>>        }
>>
>> --
>> 1.7.12
>>