[aur-dev] [PATCH 00/13] Status Update

[canyonknight at gmail.com]

On Mon, Sep 17, 2012 at 7:48 PM, Lukas Fleischer
<archlinux at cryptocrack.de> wrote:
> On Sat, Sep 15, 2012 at 12:38:06PM -0400, canyonknight wrote:

<snip>

>> The following things still need to be fixed:
>> - Account registration needs to be modified to work with URL rewriting
>
> The registration form works for me with virtual URLs enabled. Am I
> missing something?
>

Nope. It works now. Must have been broken at some point because I
wrote it down, but all is well!

>> - When a user is logged out they get the "adopt package" button on orphan
>> package pages
>
> Good catch -- we should probably wrap the whole form in an if-statement
> that checks the login status.
>

Sounds like a safe and easy solution.

>> - "View PKGBUILD" and "Download tarball" appear to be broken by rewriting
>
> I don't think we should deal with that in the code. The virtual URL
> feature requires specific rewrite rules anyway; exceptions, such as any
> files in the upload area, can be easily declared using rewrite
> conditions or "blacklist" rewrite rules.
>

Sounds good. A note somewhere in the documentation probably wouldn't
be a bad thing.

>> - Move delete and merge to "Package Actions" so that the actions bar is
>> deprecated (maybe?)
>
> Yes, I intended to do that. Initially, I even planned to move the
> package deletion form (including removal options, such as the
> confirmation check box and the target name of a merge operation) to a
> separate page. I'm not sure whether this breaks the "mass-deletion"
> feature (using check boxes and the "Actions" drop-down list on the
> package search results page), though.
>

That's what I thought. I'll explore whether it breaks "mass-deletion".

>> - Fix undefined notice when a logged out user navigates to a package page
>
> +1. That's a one-liner.
>
>> - The "Latest Comments" link appends "?comments=all" to URL on every click
>
> Yes, should be easy to fix as well.
>

Thanks!