[aur-dev] [PATCH 1/7] Allow for setting an account's inactivity status

canyonknight canyonknight at gmail.com
Tue Aug 6 06:52:44 EDT 2013


On Tue, Aug 6, 2013 at 5:50 AM, Lukas Fleischer
<archlinux at cryptocrack.de> wrote:
> On Mon, Aug 05, 2013 at 08:20:22PM -0400, canyonknight wrote:
>> On Mon, Aug 5, 2013 at 4:10 AM, Lukas Fleischer
>> <archlinux at cryptocrack.de> wrote:
>> [...]
>> > diff --git a/web/template/account_details.php b/web/template/account_details.php
>> > index fdebfb3..02ed32b 100644
>> > --- a/web/template/account_details.php
>> > +++ b/web/template/account_details.php
>> > @@ -38,6 +38,12 @@
>> >                                         <td><?= html_format_pgp_fingerprint($row["PGPKey"]) ?></td>
>> >                                 </tr>
>> >                                 <tr>
>> > +                                       <th><?= __("Status") . ":" ?></th>
>> > +                                       <td>
>> > +                                       <?= $row["InactivityTS"] ? __("Inactive since") . ' ' . date("Y-m-d H:i", $row["InactivityTS"]) : __("Active"); ?>
>>
>> Do we normally do formatted strings in these situations?
>
> Could you be a bit more specific, please? Are you referring to the
> formatted date?
>

Sorry, I was looking at the translation string. I was thinking something like:

 <?= $row["InactivityTS"] ? __("Inactive since %s", date("Y-m-d H:i",
$row["InactivityTS"])) : __("Active"); ?>

But after taking a quick look, it doesn't look like there is much
consistency in the code.

>>
>> > +                                       </td>
>> > +                               </tr>
>> > +                               <tr>
>> >                                         <th><?= __("Last Voted") . ":" ?></th>
>> >                                         <td>
>> >                                         <?= $row["LastVoted"] ? date("Y-m-d", $row["LastVoted"]) : __("Never"); ?>
>> > diff --git a/web/template/account_edit_form.php b/web/template/account_edit_form.php
>> > index a0de2a3..30b26fd 100644
>> > --- a/web/template/account_edit_form.php
>> > +++ b/web/template/account_edit_form.php
>> > @@ -56,6 +56,11 @@
>> >                 <?php endif; ?>
>> >
>> >                 <p>
>> > +                       <label for="id_inactive"><?= __("Inactive") ?>:</label>
>> > +                       <input type="checkbox" name="J" id="id_inactive" <?= $J ? 'checked="checked"' : '' ?> />
>> > +               </p>
>> > +
>> > +               <p>
>> >                         <label for="id_email"><?= __("Email Address") ?>:</label>
>> >                         <input type="text" size="30" maxlength="64" name="E" id="id_email" value="<?= htmlspecialchars($E,ENT_QUOTES) ?>" /> (<?= __("required") ?>)
>> >                 </p>
>> > --
>> > 1.8.4.rc1.383.g13e9f3f
>> >


More information about the aur-dev mailing list