[aur-dev] [PATCH] Implemented typeahead suggest

Marcel Korpel marcel.lists at gmail.com
Sun Jan 6 08:50:21 EST 2013


On Sat, Jan 5, 2013 at 9:46 PM, canyonknight <canyonknight at gmail.com> wrote:
>> +      this.$element.focus()
>
> This is not in version 2.2.1 upstream, but I see your code got pulled
> for their 2.3.0 release so this seems fine.

Good catch. I used my patched version, but only with this change.

>> +  , item: '<li><a></a></li>'
>
> This change doesn't exist upstream. So I changed it to what is in
> v2.2.1 for now. Is there anything relevant upstream? This can be a
> separate small patch in the future if it really needs to be changed.

Whoops, as I said, I used my patched version by accident. Of course
you can change this back.

I changed this, because menu items are not links whatsoever. With
anchor elements, they appear exactly like links, with a statusbar URL
that points to # and a pointer cursor. I'll propose a change upstream
in the near future. I also proposed a change to archweb.css at
https://bugs.archlinux.org/task/32989

Sorry for the inconvenience about the wrong version of bootstrap-typeahead.js.

Regards, Marcel


More information about the aur-dev mailing list