[aur-dev] [PATCH] pkgsubmit.php: Parse .SRCINFO metadata

Alexander Griesbaum agrsbm at gmail.com
Tue Mar 5 09:46:55 EST 2013

On Mar 5, 2013, at 1:37 PM, Lukas Fleischer wrote:

> +		foreach (explode("\n", $srcinfo_raw) as $line) {
> +			if ($line[0] = '#') {
> +				continue;
> +			}
> +			list($key, $value) = explode(' = ', $line, 2);

Hey, it's me again.

I think it wouldn't be bad to process the file in the same way as the PKGBUILD is processed[1]:

foreach (explode("\n", $pkgbuild_raw) as $line) {
$line = trim($line);
# Remove comments
$line = preg_replace('/\s*#.*/', '', $line);

I didn't look deep into the whole code and maybe you've got good reasons to change that procedure so please ignore my mail if you like. Though it may be unnecessairy to change the whole procedure, I really recommend to add the trim() line for more comfort.


[1] https://projects.archlinux.org/aur.git/tree/web/html/pkgsubmit.php

More information about the aur-dev mailing list