[aur-dev] [PATCH] Return 404 error page if invalid package ID is used

Lukas Fleischer archlinux at cryptocrack.de
Thu Mar 21 17:42:26 EDT 2013


We already display the 404 error page if someone tries to access an
invalid package via virtual URLs ("/packages/nonexistent"). Add the same
check to "web/html/packages.php" to make sure the same error is shown if
a user requests package details of a nonexistent package ID via legacy
URLs ("/packages.php?ID=-1").

Signed-off-by: Lukas Fleischer <archlinux at cryptocrack.de>
---
 web/html/packages.php | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/web/html/packages.php b/web/html/packages.php
index c1e54e1..a4a480c 100644
--- a/web/html/packages.php
+++ b/web/html/packages.php
@@ -18,6 +18,12 @@ if (!isset($pkgid) || !isset($pkgname)) {
 	} else {
 		unset($pkgid, $pkgname);
 	}
+
+	if (isset($pkgid) && ($pkgid == 0 || $pkgid == NULL || $pkgname == NULL)) {
+		header("HTTP/1.0 404 Not Found");
+		include "./404.php";
+		return;
+	}
 }
 
 # Set the title to the current query and get package details if required
-- 
1.8.2.480.g556678c



More information about the aur-dev mailing list