[aur-dev] [PATCH v2] Refactor pkgbase_categories()

Lukas Fleischer archlinux at cryptocrack.de
Sat Apr 5 13:58:57 EDT 2014


Signed-off-by: Lukas Fleischer <archlinux at cryptocrack.de>
---
 web/lib/pkgbasefuncs.inc.php | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/web/lib/pkgbasefuncs.inc.php b/web/lib/pkgbasefuncs.inc.php
index 5be7048..c55bd89 100644
--- a/web/lib/pkgbasefuncs.inc.php
+++ b/web/lib/pkgbasefuncs.inc.php
@@ -9,17 +9,15 @@ include_once("config.inc.php");
  * @return array All package categories
  */
 function pkgbase_categories() {
-	$cats = array();
 	$dbh = DB::connect();
 	$q = "SELECT * FROM PackageCategories WHERE ID != 1 ";
 	$q.= "ORDER BY Category ASC";
 	$result = $dbh->query($q);
-	if ($result) {
-		while ($row = $result->fetch(PDO::FETCH_NUM)) {
-			$cats[$row[0]] = $row[1];
-		}
+	if (!$result) {
+		return null;
 	}
-	return $cats;
+
+	return $result->fetchAll(PDO::FETCH_KEY_PAIR);
 }
 
 /**
-- 
1.9.1



More information about the aur-dev mailing list