[aur-dev] [PATCH/RFC 5/6] Add a warning for packages without .AURINFO

Lukas Fleischer archlinux at cryptocrack.de
Fri Jan 17 05:46:28 EST 2014


Display a deprecation warning when a package without meta data is
submitted. The user can still decide to ignore that warning by
resubmitting the package but doing so is not recommended.

Signed-off-by: Lukas Fleischer <archlinux at cryptocrack.de>
---
 web/html/pkgsubmit.php | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php
index 5d4b917..9dba945 100644
--- a/web/html/pkgsubmit.php
+++ b/web/html/pkgsubmit.php
@@ -24,6 +24,7 @@ if ($uid):
 
 	# Track upload errors
 	$error = "";
+	$ignore_missing_aurinfo = 0;
 
 	if (isset($_REQUEST['pkgsubmit'])) {
 
@@ -116,6 +117,11 @@ if ($uid):
 			if (!$error && empty($pkgbuild_raw)) {
 				$error = __("Error trying to unpack upload - PKGBUILD does not exist.");
 			}
+
+			if (!$error && empty($srcinfo_raw) && (!isset($_POST['ignore_missing_aurinfo']) || $_POST['ignore_missing_aurinfo'] != 1)) {
+				$ignore_missing_aurinfo = 1;
+				$error = __("The source package does not contain any meta data. Please use `mkaurball` to create AUR source packages. Support for source packages without .AURINFO entries will be removed in an upcoming release! You can resubmit the package if you want to proceed anyway.");
+			}
 		}
 
 		# if no error, get list of directory contents and process PKGBUILD
@@ -492,6 +498,7 @@ html_header("Submit");
 	<fieldset>
 		<div>
 			<input type="hidden" name="pkgsubmit" value="1" />
+			<input type="hidden" name="ignore_missing_aurinfo" value="<?= $ignore_missing_aurinfo ?>" />
 			<input type="hidden" name="token" value="<?= htmlspecialchars($_COOKIE['AURSID']) ?>" />
 		</div>
 		<p>
-- 
1.8.5.3



More information about the aur-dev mailing list