[aur-dev] [PATCH 1/2] Clean up user references in user_delete()

[Lukas Fleischer]

Explicitly clean up all references before deleting a user.

Signed-off-by: Lukas Fleischer <archlinux at cryptocrack.de>
---
 web/lib/acctfuncs.inc.php | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php
index 73d01a5..943e80b 100644
--- a/web/lib/acctfuncs.inc.php
+++ b/web/lib/acctfuncs.inc.php
@@ -829,6 +829,41 @@ function user_suspended($id) {
  */
 function user_delete($id) {
 	$dbh = DB::connect();
+	$id = intval($id);
+
+	/*
+	 * These are normally already taken care of by propagation constraints
+	 * but it is better to be explicit here.
+	 */
+	$fields_delete = array(
+		array("Sessions", "UsersID"),
+		array("PackageVotes", "UsersID"),
+		array("CommentNotify", "UsersID")
+	);
+
+	$fields_set_null = array(
+		array("PackageBases", "SubmitterUID"),
+		array("PackageBases", "MaintainerUID"),
+		array("PackageBases", "SubmitterUID"),
+		array("PackageComments", "UsersID"),
+		array("PackageComments", "DelUsersID"),
+		array("PackageRequests", "UsersID"),
+		array("TU_VoteInfo", "SubmitterID"),
+		array("TU_Votes", "UserID")
+	);
+
+	foreach($fields_delete as list($table, $field)) {
+		$q = "DELETE FROM " . $table . " ";
+		$q.= "WHERE " . $field . " = " . $id;
+		$dbh->query($q);
+	}
+
+	foreach($fields_set_null as list($table, $field)) {
+		$q = "UPDATE " . $table . " SET " . $field . " = NULL ";
+		$q.= "WHERE " . $field . " = " . $id;
+		$dbh->query($q);
+	}
+
 	$q = "DELETE FROM Users WHERE ID = " . $id;
 	$dbh->query($q);
 	return;
-- 
2.0.2