[aur-dev] [PATCH] Add threading headers to notification mail

[Lukas Fleischer]

On Sat, 17 May 2014 at 14:30:36, Thomas Weißschuh wrote:
> It is only basic, but works in this way for other platforms.
> Could be enhanced to include all previous comments in 'References:'
> This would require to have predictable 'Message-ID:' for notification mails.
> 
> Could also be used for out of date notifications
> ---
>  web/lib/pkgbasefuncs.inc.php | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/web/lib/pkgbasefuncs.inc.php b/web/lib/pkgbasefuncs.inc.php
> index 4d05b94..f53ff61 100644
> --- a/web/lib/pkgbasefuncs.inc.php
> +++ b/web/lib/pkgbasefuncs.inc.php
> @@ -138,6 +138,8 @@ function pkgbase_add_comment($base_id, $uid, $comment) {
>                            "Bcc: $bcc\r\n" .
>                            "Reply-to: nobody at archlinux.org\r\n" .
>                            "From: aur-notify at archlinux.org\r\n" .
> +                          "In-Reply-To: <" . $row['Name'] . "@aur.archlinux.org>\r\n" .
> +                          "References: <" . $row['Name'] . "@aur.archlinux.org>\r\n" .

I like this idea. However, I do not think the message IDs you picked are
a good choice. I would at least prefix them with "pkg-". Could you
please change that and resend?

I would also appreciate a brief remark in the commit message including
an explanation how this works (I was quite confused because we are
referencing a message ID that doesn't exist; MUAs don't seem to care
about that, though).

>                            "X-Mailer: AUR";
>                 @mail('undisclosed-recipients: ;', "AUR Comment for " . $row['Name'], $body, $headers);
>         }
> -- 
> 1.9.2
> 
>