[aur-dev] [PATCH v2] Implement capability to pin comments above others

[Mark Weiman]

On Mon, 2015-12-07 at 09:32 +0100, Lukas Fleischer wrote:
> 
> Yes, add the new columns to schema/aur-schema.sql and add a new
> section
> to upgrading/4.2.0.txt with SQL queries to upgrade an existing
> database.
> 
> Yeah, looks good to me. One minor additional nit, though. When
> checking
> this kind of preconditions, we usually write
> 
>     if (!can_pin_comment($comment_id)) {
>         return array(false, __("You are not allowed to pin this
> comment."));
>     }
> 
> and then put the main code below, without any indentation. This makes
> the code a bit easier to read/follow.
> 

I will do that then.

> 
> One more thing: It would be nice if there was a pin/unpin icon
> similar
> to the images we use for editing or deleting a comment.
> 

I will try my hardest to create one, but I'm not making any promises on
how good it will look.

> Thanks!

Mark Weiman
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part
URL: <https://lists.archlinux.org/pipermail/aur-dev/attachments/20151207/7a4e5dac/attachment.asc>