[aur-dev] [PATCH 1/3] Use username from the database if one is provided by the user

Marcel Korpel marcel.korpel at gmail.com
Mon Jul 13 14:21:03 UTC 2015

* Lukas Fleischer <lfleischer at archlinux.org> (Mon, 13 Jul 2015 09:13:24
> Could you explain why this is needed? Doesn't $N always refer to the
> correct user name? Related comment below.
> I am confused. We only call display_account_form() here if an error
> occurs *before* updating the account. Shouldn't we *always* use $N
> here, i.e. drop the create_safe_url_username() invocation above?

That would be a better solution, as this one is quite hacky: I didn't
want to change the invocation of display_account_form() in other
places, but that would be a better solution so $N always contains the
username from the database. Then we can drop the (indeed confusing)
function create_safe_url_username().

I'll try to implement this better solution and resend my patches

Best, Marcel

More information about the aur-dev mailing list