[aur-dev] [PATCH 3/3] Only output page header after account has been modified

Marcel Korpel marcel.korpel at gmail.com
Mon Jul 13 16:37:54 UTC 2015


* Marcel Korpel <marcel.korpel at gmail.com> (Mon, 13 Jul 2015 16:22:43
+0200):
> Also a better solution! We will have to send error messages through,
> though, which is not trivial. Using a GET parameter? That doesn't feel
> like the best way.

Looking better at it, it *seems* easier, as the only time we need to
use PRG is when the account modification succeeds. However, to send a
Location header, we still have to suppress output until the point the
change succeeds or errors out.

Also, leaving it the way it is, i.e., keeping this bug present, is not
nice for the user who first decides to change their username and then
wants to change other info, too. Their first attempt to do the second
step, by clicking on 'My Account' again, will fail with a 404.

Best, Marcel


More information about the aur-dev mailing list