[aur-dev] [PATCH] pkg_comments.php: Merge two DIVs with same ID

Lukas Fleischer lfleischer at archlinux.org
Tue Jul 21 15:21:09 UTC 2015


On Tue, 21 Jul 2015 at 17:01:49, Marcel Korpel wrote:
> Signed-off-by: Marcel Korpel <marcel.korpel at gmail.com>
> ---
>  web/template/pkg_comments.php | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/web/template/pkg_comments.php b/web/template/pkg_comments.php
> index 6f74349..d38c976 100644
> --- a/web/template/pkg_comments.php
> +++ b/web/template/pkg_comments.php
> @@ -63,10 +63,8 @@ $count = pkgbase_comments_count($base_id, $include_deleted);
>                         </p>
>                 </div>
>         <?php endwhile; ?>
> -</div>
>  
>  <?php if ($count > 10 && !isset($_GET['comments'])): ?>
> -<div id="news">
>         <h3>
>                 <a href="<?= htmlentities(get_pkgbase_uri($pkgbase_name), ENT_QUOTES) . '?' . mkurl('comments=all') ?>" title="<?= __('View all comments') ?> (<?= $count ?>)"><?= __('All comments', $count) ?></a>
>         </h3>

I think you also need to move the </div> line that follows these context
lines outside the if-block. Otherwise, we do not close the <div> when
there are at most 10 comments.

> -- 
> 2.4.6


More information about the aur-dev mailing list