[aur-dev] [PATCH v3 1/4] pkg_comments.php: Merge two DIVs with same ID

[Lukas Fleischer]

On Tue, 21 Jul 2015 at 21:56:56, Marcel Korpel wrote:
> Signed-off-by: Marcel Korpel <marcel.korpel at gmail.com>
> ---
> Change since v1:
> * Always close outer <div> element.
> 
>  web/template/pkg_comments.php | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/web/template/pkg_comments.php b/web/template/pkg_comments.php
> index 26fddfd..373f0ed 100644
> --- a/web/template/pkg_comments.php
> +++ b/web/template/pkg_comments.php
> @@ -62,13 +62,11 @@ $count = pkgbase_comments_count($base_id, $include_deleted);
>                                 <?= parse_comment($row['Comments']) ?>
>                         </p>
>                 </div>
> -       <?php endwhile; ?>
> -</div>
> +       <?php endwhile;

We don't merge multiple statements when using the alternative syntax for
control structures. Some please leave them as-is. Looks good otherwise!

>  
> -<?php if ($count > 10 && !isset($_GET['comments'])): ?>
> -<div id="news">
> +if ($count > 10 && !isset($_GET['comments'])): ?>
>         <h3>
>                 <a href="<?= htmlentities(get_pkgbase_uri($pkgbase_name), ENT_QUOTES) . '?' . mkurl('comments=all') ?>" title="<?= __('View all comments') ?> (<?= $count ?>)"><?= __('All comments', $count) ?></a>
>         </h3>
> -</div>
>  <?php endif; ?>
> +</div>
> -- 
> 2.4.6